Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Interdimensionale Gesellschaft mbH' (community contribution) #2240

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"pr0gramm.com"
],
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (DE-64521 Groß-Gerau) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau",
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau\nGermany",
Suggested change
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau",
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau\nDeutschland",

"runs": [
"pr0gramm.com"
],
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "Interdimensionale Gesellschaft mbH\nRathausstr. 4\nDE-64521 Groß-Gerau",
"address": "Rathausstr. 4\nDE-64521 Groß-Gerau",

Comment on lines 23 to 34
"required-elements": [
{
"desc": "Benutzername",
"type": "input",
"optional": false
},
{
"desc": "E-Mail Adresse",
"type": "input",
"optional": false
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [companylint] <name-in-required-elements> reported by reviewdog 🐶
Record has required elements but no name element.

@baltpeter baltpeter enabled auto-merge (squash) September 26, 2023 06:14
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 7ba5393 into datenanfragen:master Sep 26, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_pr0gramm_1687714598010 branch September 26, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants