Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'The Constant Company, LLC' (community contribution) #2251

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"Vultr.com"
],
"address": "The Constant Company, LLC,\n 319 Clematis Street Suite 900,\n West Palm Beach, \nFL 33401, USA",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (FL 33401, USA) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"Vultr.com"
],
"address": "The Constant Company, LLC,\n 319 Clematis Street Suite 900,\n West Palm Beach, \nFL 33401, USA",
"phone": "+55 349820192",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "+55 349820192"
}

"runs": [
"Vultr.com"
],
"address": "The Constant Company, LLC,\n 319 Clematis Street Suite 900,\n West Palm Beach, \nFL 33401, USA",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address aren't trimmed (at least one line contains trailing or leading whitespace).

Suggested change
"address": "The Constant Company, LLC,\n 319 Clematis Street Suite 900,\n West Palm Beach, \nFL 33401, USA",
"address": "The Constant Company, LLC,\n319 Clematis Street Suite 900,\nWest Palm Beach,\nFL 33401, USA",

@baltpeter baltpeter enabled auto-merge (squash) September 26, 2023 06:24
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 5a4a348 into datenanfragen:master Sep 26, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_vultr_1688790873357 branch September 26, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants