Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'American Express Europe S.A.' (community contribution) #2301

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Aug 7, 2023
@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_american-express-europe-s-a-germany-branch_1691446115084 branch from 38fe23a to d1ad4d7 Compare August 7, 2023 22:08
"all"
],
"name": "American Express Europe S.A. (Germany branch)",
"address": "Datenschutzbeauftragter, Theodor-Heuss-Allee 112, 60486 Frankfurt a.M",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Datenschutzbeauftragter, Theodor-Heuss-Allee 112, 60486 Frankfurt a.M",
"address": "Datenschutzbeauftragter\nTheodor-Heuss-Allee 112\n60486 Frankfurt a.M",

"all"
],
"name": "American Express Europe S.A. (Germany branch)",
"address": "Datenschutzbeauftragter, Theodor-Heuss-Allee 112, 60486 Frankfurt a.M",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Datenschutzbeauftragter, Theodor-Heuss-Allee 112, 60486 Frankfurt a.M) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

Comment on lines 17 to 23
"required-elements": [
{
"desc": "Kreditkartennummer",
"type": "input",
"optional": false
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [companylint] <name-in-required-elements> reported by reviewdog 🐶
Record has required elements but no name element.

@baltpeter baltpeter changed the title Add 'American Express Europe S.A. (Germany branch)' (community contribution) Add 'American Express Europe S.A.' (community contribution) Sep 26, 2023
@baltpeter baltpeter enabled auto-merge (squash) September 26, 2023 07:29
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 4ed5d11 into datenanfragen:master Sep 26, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_american-express-europe-s-a-germany-branch_1691446115084 branch September 26, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants