Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'RheinLand Versicherungs AG' (community contribution) #2327

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_rheinland-versicherungen_1692882437616 branch from 9f152ee to baf8973 Compare August 24, 2023 13:07
@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Aug 24, 2023
"runs": [
"RheinLand Versicherungs AG"
],
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (41460 Neuss) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss",
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss\nGermany",
Suggested change
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss",
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss\nDeutschland",

"RheinLand Versicherungs AG"
],
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss",
"phone": "02131 290-0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "02131 290-0"
}

],
"address": "RheinLand Versicherungs AG\nRheinLandplatz\n41460 Neuss",
"phone": "02131 290-0",
"fax": "02131 290-13300",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "02131 290-13300"
}

@baltpeter baltpeter changed the title Add 'RheinLand Versicherungen' (community contribution) Add 'RheinLand Versicherungs AG' (community contribution) Sep 26, 2023
@baltpeter baltpeter enabled auto-merge (squash) September 26, 2023 08:50
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 3732b7b into datenanfragen:master Sep 26, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_rheinland-versicherungen_1692882437616 branch September 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants