New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Brose Fahrzeugteile SE & Co. KG' (community contribution) #2339
Add 'Brose Fahrzeugteile SE & Co. KG' (community contribution) #2339
Conversation
a75ed1a
to
6c0e074
Compare
companies/brose-fahrzeugteile.json
Outdated
], | ||
"categories": [], | ||
"name": "Brose Fahrzeugteile", | ||
"address": "Max-Brose-Straße 1, 96450 Coburg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address
are not separated by newlines (\n).
"address": "Max-Brose-Straße 1, 96450 Coburg", | |
"address": "Max-Brose-Straße 1\n96450 Coburg", |
companies/brose-fahrzeugteile.json
Outdated
], | ||
"categories": [], | ||
"name": "Brose Fahrzeugteile", | ||
"address": "Max-Brose-Straße 1, 96450 Coburg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address
(Max-Brose-Straße 1, 96450 Coburg
) is not a country.
We've decided on specific variations for these countries:
United States of America
The Netherlands
Republic of Singapore
companies/brose-fahrzeugteile.json
Outdated
"name": "Brose Fahrzeugteile", | ||
"address": "Max-Brose-Straße 1, 96450 Coburg", | ||
"sources": [ | ||
"Www.brose.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”
Raw error:
{
"path": "$.sources[0]",
"pointer": "/sources/0",
"message": "The value at /sources/0 must be a valid URI string but it was not.",
"data": "Www.brose.com"
}
"Www.brose.com", | ||
"https://github.com/datenanfragen/data/pull/2339" | ||
], | ||
"suggested-transport-medium": "email", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <suggested-medium-exists> reported by reviewdog 🐶
Suggested-transport-medium is set to 'email', but the email is not defined in the record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator