Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Brose Fahrzeugteile SE & Co. KG' (community contribution) #2339

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Sep 6, 2023
],
"categories": [],
"name": "Brose Fahrzeugteile",
"address": "Max-Brose-Straße 1, 96450 Coburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Max-Brose-Straße 1, 96450 Coburg",
"address": "Max-Brose-Straße 1\n96450 Coburg",

],
"categories": [],
"name": "Brose Fahrzeugteile",
"address": "Max-Brose-Straße 1, 96450 Coburg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Max-Brose-Straße 1, 96450 Coburg) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"name": "Brose Fahrzeugteile",
"address": "Max-Brose-Straße 1, 96450 Coburg",
"sources": [
"Www.brose.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /sources/0 must be a valid URI string but it was not.”

Raw error:

{
    "path": "$.sources[0]",
    "pointer": "/sources/0",
    "message": "The value at /sources/0 must be a valid URI string but it was not.",
    "data": "Www.brose.com"
}

"Www.brose.com",
"https://github.com/datenanfragen/data/pull/2339"
],
"suggested-transport-medium": "email",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <suggested-medium-exists> reported by reviewdog 🐶
Suggested-transport-medium is set to 'email', but the email is not defined in the record.

@baltpeter baltpeter changed the title Add 'Brose Fahrzeugteile' (community contribution) Add 'Brose Fahrzeugteile SE & Co. KG' (community contribution) Sep 26, 2023
@baltpeter baltpeter enabled auto-merge (squash) September 26, 2023 09:07
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 9685857 into datenanfragen:master Sep 26, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_brose-fahrzeugteile_1694023984652 branch September 26, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants