Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'jameda GmbH' (community contribution) #2343

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"danke-coronahelden.de",
"jameda - Für Ihre Gesundheit (App)"
],
"address": "jameda GmbH\n\nBalanstraße 71a\n\n81541 München",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (81541 München) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"danke-coronahelden.de",
"jameda - Für Ihre Gesundheit (App)"
],
"address": "jameda GmbH\n\nBalanstraße 71a\n\n81541 München",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "jameda GmbH\n\nBalanstraße 71a\n\n81541 München",
"address": "\nBalanstraße 71a\n\n81541 München",

"jameda - Für Ihre Gesundheit (App)"
],
"address": "jameda GmbH\n\nBalanstraße 71a\n\n81541 München",
"phone": "089 / 2019 44 94",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "089 / 2019 44 94"
}

],
"address": "jameda GmbH\n\nBalanstraße 71a\n\n81541 München",
"phone": "089 / 2019 44 94",
"fax": "0800 / 111 237 686",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "0800 / 111 237 686"
}

@baltpeter baltpeter enabled auto-merge (squash) September 26, 2023 09:11
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 75feaa6 into datenanfragen:master Sep 26, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_jameda_1694097332422 branch September 26, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants