Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Flattr AB' (community contribution) #2380

Merged
merged 2 commits into from Oct 6, 2023
Merged

Add 'Flattr AB' (community contribution) #2380

merged 2 commits into from Oct 6, 2023

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Oct 4, 2023
@rugk
Copy link
Contributor

rugk commented Oct 4, 2023 •
edited

My PR (would love it if you could signup with your GitHub account o have it associated [like on https://webcompat.com, which seems to work similar)… BTW. (Or shall I open a new issue for that?)

datenanfragen-bot
datenanfragen-bot reviewed Oct 4, 2023
View reviewed changes
companies/flattr-eyeo.json Outdated
Comment on lines 17 to 23
"required-elements": [
{
"desc": "E-Mail",
"type": "email",
"optional": false
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [companylint] <name-in-required-elements> reported by reviewdog 🐶
Record has required elements but no name element.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see how to enter that in the web form, it had a "Name:" that appeared here as a "desc".

Copy link
Member

@baltpeter baltpeter Oct 6, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, the wording maybe isn't clear enough. This actually doesn't refer to a property name on a required element but rather to one required element of type: name, see the linked documentation.

@baltpeter
Copy link
Member

My PR (would love it if you could signup with your GitHub account o have it associated [like on webcompat.com, which seems to work similar)… BTW. (Or shall I open a new issue for that?)

I am actually currently working on something just like that. It's currently in a pre-alpha state though and it will take some time until I can properly release it.

@baltpeter baltpeter changed the title Add 'Flattr (Eyeo)' (community contribution) Add 'Flattr AB' (community contribution) Oct 6, 2023
@baltpeter baltpeter enabled auto-merge (squash) October 6, 2023 08:46
baltpeter
baltpeter approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 44bc3af into datenanfragen:master Oct 6, 2023
0 of 2 checks passed
@baltpeter baltpeter deleted the suggest_flattr-eyeo_1696454967778 branch October 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk left review comments

@datenanfragen-bot datenanfragen-bot datenanfragen-bot left review comments

@baltpeter baltpeter baltpeter approved these changes

Assignees
No one assigned
Labels
record Issue related to the JSON records via-suggest-api
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@datenanfragen-community-edits @rugk @baltpeter @datenanfragen-bot