Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Ideal Inkasso UG' (community contribution) #2385

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Oct 7, 2023
"collection agency"
],
"name": "Ideal Inkasso UG",
"address": "Westerfeldstr. 37\n33611 Bielefeld",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (33611 Bielefeld) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Westerfeldstr. 37\n33611 Bielefeld",
"address": "Westerfeldstr. 37\n33611 Bielefeld\nGermany",
Suggested change
"address": "Westerfeldstr. 37\n33611 Bielefeld",
"address": "Westerfeldstr. 37\n33611 Bielefeld\nDeutschland",

],
"name": "Ideal Inkasso UG",
"address": "Westerfeldstr. 37\n33611 Bielefeld",
"phone": "0521/44815246",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "0521/44815246"
}

"name": "Ideal Inkasso UG",
"address": "Westerfeldstr. 37\n33611 Bielefeld",
"phone": "0521/44815246",
"fax": "0521/44815245",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”

Raw error:

{
    "path": "$.fax",
    "pointer": "/fax",
    "message": "The value at /fax is an invalid string.",
    "data": "0521/44815245"
}

@baltpeter
Copy link
Member

We already have an entry for IDEAL-INKASSO but looks like we need to update that: https://www.datenanfragen.de/company/ideal-inkasso

@baltpeter
Copy link
Member

We already have an entry for IDEAL-INKASSO but looks like we need to update that: datenanfragen.de/company/ideal-inkasso

Actually, seems like I was wrong. As far as I can tell, those are two different companies, as confirmed by this message on FragDenStaat.

@baltpeter baltpeter enabled auto-merge (squash) November 27, 2023 09:50
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 30c357b into datenanfragen:master Nov 27, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_ideal-inkasso-ug_1696689866910 branch November 27, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants