New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Ideal Inkasso UG' (community contribution) #2385
Add 'Ideal Inkasso UG' (community contribution) #2385
Conversation
90d18d2
to
a31e293
Compare
companies/ideal-inkasso-ug.json
Outdated
| "collection agency" | ||
| ], | ||
| "name": "Ideal Inkasso UG", | ||
| "address": "Westerfeldstr. 37\n33611 Bielefeld", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (33611 Bielefeld) is not a country.
We've decided on specific variations for these countries:
United States of AmericaThe NetherlandsRepublic of Singapore
| "address": "Westerfeldstr. 37\n33611 Bielefeld", | |
| "address": "Westerfeldstr. 37\n33611 Bielefeld\nGermany", |
| "address": "Westerfeldstr. 37\n33611 Bielefeld", | |
| "address": "Westerfeldstr. 37\n33611 Bielefeld\nDeutschland", |
companies/ideal-inkasso-ug.json
Outdated
| ], | ||
| "name": "Ideal Inkasso UG", | ||
| "address": "Westerfeldstr. 37\n33611 Bielefeld", | ||
| "phone": "0521/44815246", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”
Raw error:
{
"path": "$.phone",
"pointer": "/phone",
"message": "The value at /phone is an invalid string.",
"data": "0521/44815246"
}
companies/ideal-inkasso-ug.json
Outdated
| "name": "Ideal Inkasso UG", | ||
| "address": "Westerfeldstr. 37\n33611 Bielefeld", | ||
| "phone": "0521/44815246", | ||
| "fax": "0521/44815245", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”
Raw error:
{
"path": "$.fax",
"pointer": "/fax",
"message": "The value at /fax is an invalid string.",
"data": "0521/44815245"
}|
We already have an entry for IDEAL-INKASSO but looks like we need to update that: https://www.datenanfragen.de/company/ideal-inkasso |
Actually, seems like I was wrong. As far as I can tell, those are two different companies, as confirmed by this message on FragDenStaat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator