Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Frankfurter Societäts-Medien GmbH' (community contribution) #2411

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"Frankfurter Neue Presse (FNP)"
],
"address": "Hedderichstraße 49\n60594 Frankfurt \nDeutschland",
"phone": "Tel: (069) 75 01-0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "Tel: (069) 75 01-0"
}

"runs": [
"Frankfurter Neue Presse (FNP)"
],
"address": "Hedderichstraße 49\n60594 Frankfurt \nDeutschland",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address aren't trimmed (at least one line contains trailing or leading whitespace).

Suggested change
"address": "Hedderichstraße 49\n60594 Frankfurt \nDeutschland",
"address": "Hedderichstraße 49\n60594 Frankfurt\nDeutschland",

@baltpeter baltpeter enabled auto-merge (squash) October 20, 2023 13:07
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 207c166 into datenanfragen:master Oct 20, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_fnp_1697551374988 branch October 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants