Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Veja Faire Trade SARL' (community contribution) #2417

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Oct 17, 2023
@datenanfragen-community-edits datenanfragen-community-edits force-pushed the suggest_veja-faire-trade-sarl_1697571737570 branch from eec403c to b2d4fbd Compare October 17, 2023 19:42
"commerce"
],
"name": "Veja Faire Trade SARL",
"address": "146 rue du Faubourg Poissonnière\n 75010 Paris\nFrankreich",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Frankreich) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"commerce"
],
"name": "Veja Faire Trade SARL",
"address": "146 rue du Faubourg Poissonnière\n 75010 Paris\nFrankreich",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address aren't trimmed (at least one line contains trailing or leading whitespace).

Suggested change
"address": "146 rue du Faubourg Poissonnière\n 75010 Paris\nFrankreich",
"address": "146 rue du Faubourg Poissonnière\n75010 Paris\nFrankreich",

@baltpeter baltpeter enabled auto-merge (squash) October 20, 2023 13:14
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit f77f17c into datenanfragen:master Oct 20, 2023
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_veja-faire-trade-sarl_1697571737570 branch October 20, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants