New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ':data factory GmbH' (community contribution) #2437
Add ':data factory GmbH' (community contribution) #2437
Conversation
143ead6
to
bd37ac1
Compare
companies/data-factory.json
Outdated
| "telecommunication" | ||
| ], | ||
| "name": ":data factory GmbH", | ||
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (86633 Neuburg) is not a country.
We've decided on specific variations for these countries:
United States of AmericaThe NetherlandsRepublic of Singapore
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg", | |
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg\nGermany", |
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg", | |
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg\nDeutschland", |
companies/data-factory.json
Outdated
| ], | ||
| "name": ":data factory GmbH", | ||
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg", | ||
| "phone": "0 84 31/ 6 47 39-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”
Raw error:
{
"path": "$.phone",
"pointer": "/phone",
"message": "The value at /phone is an invalid string.",
"data": "0 84 31/ 6 47 39-0"
}
companies/data-factory.json
Outdated
| "name": ":data factory GmbH", | ||
| "address": "Dr.-Karl-Lexer-Weg B300\n86633 Neuburg", | ||
| "phone": "0 84 31/ 6 47 39-0", | ||
| "fax": "0 84 31/ 6 47 39-19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /fax is an invalid string.”
Raw error:
{
"path": "$.fax",
"pointer": "/fax",
"message": "The value at /fax is an invalid string.",
"data": "0 84 31/ 6 47 39-19"
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This suggestion was submitted through the website.
Edit in company JSON generator