Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New company suggestion: 'Barmenia Versicherungen a. G.' #691

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit

@datenanfragen-community-edits datenanfragen-community-edits added record Issue related to the JSON records via-suggest-api labels Aug 25, 2020
@baltpeter baltpeter self-assigned this Aug 25, 2020
@baltpeter baltpeter merged commit 199c718 into datenanfragen:master Aug 25, 2020
@m-rey
Copy link
Collaborator

m-rey commented Aug 25, 2020

That was fast!
Now that the community edits create a PR instead of an issue, to fix suggestions, I need to make the changes in the corresponding branch of datenanfragen-community-edits/data, right?

In that case, could I also get commit rights to datenanfragen-community-edits/data?

On another note, if each suggestion creates a PR, does this trigger the CI every time? If so, I remember that this was a problem before. Has this improved?

@baltpeter
Copy link
Member

That was fast!

Yep, thanks to the great changes by @mal-tee and @zner0L, reviewing suggestions is a lot easier now!

Now that the community edits create a PR instead of an issue, to fix suggestions, I need to make the changes in the corresponding branch of datenanfragen-community-edits/data, right?

Exactly, as you are a maintainer in this repo, you should have the rights to write directly to the branch (the PRs automatically tick the 'Allow edits by maintainers' checkbox). You should be able to just use the 'Edit file' button in the 'Files changed' tab. Alternatively, you should also be able to directly push to the respective branch from the desktop.

Let me know if this doesn't work.

On another note, if each suggestion creates a PR, does this trigger the CI every time? If so, I remember that this was a problem before. Has this improved?

Yes, each suggestion triggers the CI checks. That should not be an issue though, as they are very lightweight and complete in a matter of seconds. This also has the benefit of directly highlighting any potential problems directly under the suggestion.

@m-rey
Copy link
Collaborator

m-rey commented Sep 1, 2020

Let me know if this doesn't work.

Maybe I did it wrong, but when navigating to the corresponding branch of a PR and trying to upload an updated file to it via the web interface, the following error message appears:

Uploads are disabled.
File uploads require push access to this repository.

I also don't see a 'Edit file' button in the 'Files changed' tab of the PR.

@zner0L
Copy link
Member

zner0L commented Sep 1, 2020

I also don't see a 'Edit file' button in the 'Files changed' tab of the PR.

There should be a "Edit File" Link in the three dot menu in the "Files Changed" tab on the top right of each file. Do you see that? Otherwise, I would suspect your role does not have the right permissions (even though the checkbox explicitly says "Maintainers").

Let me now!

@m-rey
Copy link
Collaborator

m-rey commented Sep 1, 2020

Okay, my bad. Thanks for the help!

I was looking at an already merged PR. I guess that's why I couldn't edit the file.

@baltpeter baltpeter deleted the suggest_barmeniade_1598353208436 branch April 19, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

4 participants