Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datenanfragen.de v2: complaint generator and new UX #921

Merged
merged 185 commits into from
Dec 6, 2022
Merged

Datenanfragen.de v2: complaint generator and new UX #921

merged 185 commits into from
Dec 6, 2022

Conversation

baltpeter
Copy link
Member

@baltpeter baltpeter commented Aug 3, 2022 •
edited by zner0L
Loading

Edit by @zner0L: Thanks to the Prototype Fund from the German Ministry of Education and Research, we were able to completely redesign the generator.

Most noteable changes:

  • Simpler generator (especially for mass requests)
  • More comprehensive "My requests" page, with better request state tracking
  • A reaction wizard with built-in complaint generator
  • A nice and less convoluted homepage
  • Cleaner code and proper state management for less race conditions
  • @datenanfragen/components npm package to make the generator pluggable into external websites

zner0L and others added 19 commits July 15, 2022 11:17
@zner0L @baltpeter
Add Proceeding data type
fcb1405
@zner0L @baltpeter
Use localforage for storing
14afa80
@zner0L @baltpeter
Add migration for old user requests
46e7e58
@zner0L @baltpeter
Add migration for the edge case with no parent request
ba38493
@zner0L @baltpeter
Wrap localforage in a conditional wrapper to allow for privacy checks
84e6149
@zner0L @baltpeter
Add test for migrating the users requests
65a711a
@baltpeter @zner0L
New UX design for the request generator (#895)
73ffffc 
This commit implements a new UX design for the request generator that will eventually
replace the existing one.

The new design most notably uses a wizard-style flow to guide the user through the
process instead of overwhelming them with all questions on a single page like the
initial design.

The design is not finalized yet, and we will continue to iterate on it. Major open issues are
listed in #910.

Co-authored-by: Lorenz Sieben <me@lorenz-sieben.com>
Co-authored-by: Benjamin Altpeter <benjamin@oldpeter.de>
@zner0L @baltpeter
Add request type icons
21f0e42
@zner0L @baltpeter
Properly hydrate dates in messages
c45fde6
@zner0L @baltpeter
Implement new UI for proceedings
2a1cb0e
@zner0L @baltpeter
Add directionality to messages
d1a3f85
@zner0L @baltpeter
Add proceeding actions and deselection button
9a3622f
@zner0L @baltpeter
Add factory and person icon
67ddc24
@zner0L @baltpeter
Add a manual import message modal
5ebb0b1
@zner0L @baltpeter
Create our custom localforage replacement to prevent race conditions
14a25bb
@zner0L @baltpeter
Convert privacy controls to TypeScript and add proper request clearing
bdc693e
@zner0L @baltpeter
Basic regular status updates for proceedings
8efedd5
@zner0L @baltpeter
Fix broken tests
bf3a8f2 
Note that the admonition and complaint tests still fail because the bahaviour is not yet implemented.
@zner0L @baltpeter
Address suggestions from code review
2a1dd9f
@baltpeter baltpeter added the invalid This doesn't seem right label Aug 9, 2022
@baltpeter baltpeter changed the title WIP: Deploy preview WIP: Just for the deploy preview (new_ux) Aug 9, 2022
baltpeter and others added 20 commits December 6, 2022 12:24
@baltpeter @zner0L
Fix date formatting in proceedings test
ccab4ac
@baltpeter @zner0L
Test that company packs change based on the country
ace3140
@baltpeter @zner0L
Reactor: Some dead ends forgot not to include the issue
7c339fc
@baltpeter @zner0L
Reactor: Hide issues with additional data already provided
2ab47dc
@baltpeter @zner0L
Use case tests for reactor
6f11e36
@baltpeter @zner0L
Tests: Get rid of Percy
e7afa69 
This has broken broken for ages. We may well want to try and re-enable
Percy in the future, but then we'll have to start from scratch anyway.
@baltpeter @zner0L
Tests: Ensure that CompanySearchPage respects privacy control
5dd018a
@baltpeter @zner0L
Tests: Request tracking status in the generator
5f4b56c
@baltpeter @zner0L
Generator tests: Use containsSettled liberally
715c3bc 
Tests were intermittently failing due to detached elements.
@baltpeter @zner0L
Fix date in migration test
bc403ab 
We've waited long enough for the static date requests to become
`overdue` instead of `waitingForResponse`…
@baltpeter @zner0L
AdvGen: Also clear 'companies' URL parameter
24ac674
@baltpeter @zner0L
Test URL parameters in generator
559bcb3
@baltpeter @zner0L
Tests: Wait for generatorStore to become available
fde936f
@baltpeter @zner0L
Tests: Don't swallow Hugo output to make debugging possible
149f521
@baltpeter @zner0L
Fix tests failing due to Facebook rename (cf. #962)
4dee03e
@baltpeter @zner0L
Circle config: Use higher resource class
bce2c2e 
This is just a stab in the dark but it might fix the problems with
the site becoming unavailable during the tests intermittently.

At the very least, it should speed up the runs a little.
@zner0L
Use waitUntil for generatorStoreApi and allow multiple stores per page
c5861cc
@zner0L
Temp fix: Disable tests that depend on the generator store test inter…
e4c9239 
…face
@zner0L
Fix tests after rebase
53304fa
@baltpeter
Merge branch 'master' into new_ux
6a75ea9
@baltpeter baltpeter removed the invalid This doesn't seem right label Dec 6, 2022
@baltpeter baltpeter marked this pull request as ready for review December 6, 2022 11:53
baltpeter
baltpeter commented Dec 6, 2022
View reviewed changes
Copy link
Member Author

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@zner0L zner0L self-requested a review December 6, 2022 13:11
zner0L
zner0L approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@zner0L zner0L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check all files again, but the merge changes check out. Approved. How exciting!

@zner0L zner0L merged commit 14f18a9 into master Dec 6, 2022
@zner0L zner0L deleted the new_ux branch December 6, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zner0L zner0L zner0L approved these changes

Assignees
No one assigned
Labels
feature optimization refactoring UI/UX
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baltpeter @zner0L