From 8efe253059b442984f46358d058fd6b71fbf5e58 Mon Sep 17 00:00:00 2001
From: Paul Ganssle <paul@ganssle.io>
Date: Thu, 2 Jan 2020 11:54:27 -0500
Subject: [PATCH] Fix custom repr for ParserError

This was originally dead code, because an indentation error had `__repr__`
defined after the `return` statement in `__str__`. The definition of the
`__repr__` is also changed to be more in line with the conception of a
repr as "what you would have to evalue to get this object".

Even though this is not guaranteed behavior, this commit also adds a
regression test to avoid simple errors like this in the future.
---
 changelog.d/991.bugfix.rst   | 1 +
 dateutil/parser/_parser.py   | 5 +++--
 dateutil/test/test_parser.py | 9 +++++++++
 3 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 changelog.d/991.bugfix.rst

diff --git a/changelog.d/991.bugfix.rst b/changelog.d/991.bugfix.rst
new file mode 100644
index 000000000..473082e82
--- /dev/null
+++ b/changelog.d/991.bugfix.rst
@@ -0,0 +1 @@
+Fixed the custom ``repr`` for ``dateutil.parser.ParserError``, which was not defined due to an indentation error. (gh issue #991, gh pr #993)
diff --git a/dateutil/parser/_parser.py b/dateutil/parser/_parser.py
index 458aa6a32..b3077c97b 100644
--- a/dateutil/parser/_parser.py
+++ b/dateutil/parser/_parser.py
@@ -1600,8 +1600,9 @@ def __str__(self):
         except (TypeError, IndexError):
             return super(ParserError, self).__str__()
 
-        def __repr__(self):
-            return "%s(%s)" % (self.__class__.__name__, str(self))
+    def __repr__(self):
+        args = ", ".join("'%s'" % arg for arg in self.args)
+        return "%s(%s)" % (self.__class__.__name__, args)
 
 
 class UnknownTimezoneWarning(RuntimeWarning):
diff --git a/dateutil/test/test_parser.py b/dateutil/test/test_parser.py
index 726156c8d..6579e2636 100644
--- a/dateutil/test/test_parser.py
+++ b/dateutil/test/test_parser.py
@@ -939,3 +939,12 @@ def test_decimal_error(value):
     # when constructed with an invalid value
     with pytest.raises(ParserError):
         parse(value)
+
+def test_parsererror_repr():
+    # GH 991 — the __repr__ was not properly indented and so was never defined.
+    # This tests the current behavior of the ParserError __repr__, but the
+    # precise format is not guaranteed to be stable and may change even in
+    # minor versions. This test exists to avoid regressions.
+    s = repr(ParserError("Problem with string: %s", "2019-01-01"))
+
+    assert s == "ParserError('Problem with string: %s', '2019-01-01')"