fix(analysis): pass reserved/prefix to safenames sanitize call (rebases #267)#293
Merged
Conversation
Brings the qsv ``safenames --mode conditional`` (sanitize) call into parity with the ``--mode json`` (detect) call directly above. The detect call already passes ``reserved=conf.RESERVED_COLNAMES`` and ``prefix=conf.UNSAFE_PREFIX``; the sanitize call did not, so qsv fell back to its built-in defaults — which could disagree with the detection rules and produce renamed columns that didn't match what was reported as unsafe. Originally fixed in PR #267 by @minhajuddin2510 against the pre-migration ``jobs.py`` (deleted by the Prefect 3 migration); this PR carries the equivalent change to the new ``jobs/stages/analysis.py`` location. Closes #267. Co-Authored-By: @minhajuddin2510 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks #267 (by @minhajuddin2510) onto current main. The migration deleted `jobs.py` (where #267's 1-line change lived) so the original PR became dead-on-main — same situation as #270.
What the change does
Brings the qsv `safenames --mode conditional` (sanitize) call into parity with the `--mode json` (detect) call directly above it in `analysis.py`. The detect call already passes `reserved=conf.RESERVED_COLNAMES` + `prefix=conf.UNSAFE_PREFIX`; the sanitize call didn't, so qsv fell back to its built-in defaults — which could disagree with the detection rules and produce renamed columns that didn't match what was reported as unsafe.
Tests
95/95 unit tests pass in `dpp-test`.
Test plan
🤖 Generated with Claude Code