Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor,#8][l]: Set up dir structure for Python package #27

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

sglavoie
Copy link
Contributor

  • This is necessary to be able to deploy to PyPi and to have make test
    run successfully with a properly configured setup.py.

@hannelita, this should be good to go! Making those changes by basically creating the aircan directory and moving the code there makes the command make test run successfully as it has the proper structure for a Python package.

Please let me know if any change is required. I can run make test locally, dependencies are installed and tests are run (but still failing).

* This is necessary to be able to deploy to PyPi and to have `make test`
  run successfully with a properly configured `setup.py`.
@sglavoie sglavoie requested a review from hannelita June 18, 2020 15:21
@hannelita hannelita mentioned this pull request Jun 18, 2020
14 tasks
@hannelita hannelita merged commit 808046d into master Jun 18, 2020
@hannelita hannelita deleted the refactor/dir-structure-to-package branch June 18, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants