[tagline][s] adds home heading from wp #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes: 'I have added a tagline in Wordpress. Please use this as tagline instead of "Velkommen til Open Data DK"' from https://gitlab.com/datopian/ckan-next-gen/issues/121#final-round
anuveyatsu
reviewed
Oct 29, 2019
fixtures/index.js
Outdated
| 'max-age=15552000' ]); | ||
|
|
||
| nock('https://public-api.wordpress.com:443', {"encodedQueryParams":true}) | ||
| .get('/rest/v1.1/sites/https%3A%2F%2Foddk.home.blog%2F') |
Member
There was a problem hiding this comment.
This should use mocked endpoint:
.get('/rest/v1.1/sites/http%3A%2F%2F127.0.0.1%3A6000%2F')
Contributor
Author
There was a problem hiding this comment.
If I run npm run test locally a lot of the tests fail, and Travis also was not satisfied with .get('/rest/v1.1/sites/http%3A%2F%2F127.0.0.1%3A6000%2F')
Member
There was a problem hiding this comment.
@EvgeniiaVak I guess if you remove trailing slash it might succeed:
.get('/rest/v1.1/sites/http%3A%2F%2F127.0.0.1%3A6000')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes:
'I have added a tagline in Wordpress. Please use this as tagline instead of "Velkommen til Open Data DK"' from https://gitlab.com/datopian/ckan-next-gen/issues/121#final-round