Table schema field name missing fixed on custom dictionary. #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sagargg-zz
commented
Mar 5, 2020
sagargg-zz
commented
- Missing name field fixed when we use custom data dictionary.
anuveyatsu
reviewed
Mar 5, 2020
| type: dataDictionaryType2TableSchemaType[dataDictionary.type] || 'any' | ||
| } | ||
| if (dataDictionary.info) { | ||
| field.name = dataDictionary.info.title || dataDictionary.id |
Member
There was a problem hiding this comment.
@sagargg this looks wrong to me. name is the identifier in tableschema so it should be equal to dataDictionary.id, while title is the different thing.
Member
|
Closing this as INVALID. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.