Skip to content

Table schema field name missing fixed on custom dictionary. #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Table schema field name missing fixed on custom dictionary. #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00600c4
[utlis][xs]:table schema field name missing fixed
sagargg Mar 5, 2020
b987f2e
[xs]: test fail fixed
sagargg Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/utils/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ test('datastore data dictionary => tableschema', t => {
t.deepEqual(result, expected)

result = utils.dataStoreDataDictionaryToTableSchema({
id: 'column',
id: 'Column',
type: 'text',
info: {
title: 'Column',
Expand All @@ -224,7 +224,7 @@ test('datastore data dictionary => tableschema', t => {
})

expected = {
name: 'column',
name: 'Column',
type: 'string',
title: 'Column',
constraints: {
Expand Down
1 change: 1 addition & 0 deletions utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ module.exports.dataStoreDataDictionaryToTableSchema = (dataDictionary) => {
type: dataDictionaryType2TableSchemaType[dataDictionary.type] || 'any'
}
if (dataDictionary.info) {
field.name = dataDictionary.info.title || dataDictionary.id
Copy link
Member

@anuveyatsu anuveyatsu Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagargg this looks wrong to me. name is the identifier in tableschema so it should be equal to dataDictionary.id, while title is the different thing.

const constraintsAttributes = ['required', 'unique', 'minLength', 'maxLength', 'minimum', 'maximum', 'pattern', 'enum']
field.constraints = {}
Object.keys(dataDictionary.info).forEach(key => {
Expand Down