[CMS][m]: Refactor WP CMS backend as plugin #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuveyatsu
approved these changes
Aug 2, 2019
Member
anuveyatsu
left a comment
anuveyatsu
left a comment
There was a problem hiding this comment.
I'm approving this PR as it looks good 👍
I want to flag that I didn't know that we were planning to factor out WP CMS as a plugin. My initial understanding was that we're adding another CMS plugin (eg, CKAN pages) that overrides built-in WP CMS.
On the other hand, I think this implementation is nice because:
- we're now explicitly defining WP as a CMS
- allowing users to not have CMS at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Wordpress CMS backend as plugin.