Skip to content

[opendk][s]: consolidate data format #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anuveyatsu merged 1 commit into from
Sep 10, 2019
Merged

[opendk][s]: consolidate data format #75

anuveyatsu merged 1 commit into from
Sep 10, 2019

Conversation

@sagargg-zz
Copy link
Contributor

@sagargg-zz sagargg-zz commented Sep 10, 2019

  • Applied colored in Data format of resources
  • Duplicate data format removed
  • groups and organizations alphabetically sorted

@sagargg
[opendk][s]: consolidate data format - duplicate removed, colored for…
e19643b 
…mat & groups and organisations alphabetically Sorted
anuveyatsu
anuveyatsu reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@anuveyatsu anuveyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagargg that's great. What if we receive unknown data format? Would it use some default color?

@sagargg-zz
Copy link
Contributor Author

sagargg-zz commented Sep 10, 2019

@anuveyatsu there is the tailwind bg-gray-600 it will only override if the format is known

@anuveyatsu anuveyatsu merged commit 30af228 into datopian:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuveyatsu anuveyatsu anuveyatsu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sagargg-zz @anuveyatsu @sagargg