New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the terminal is not very wide, 'connected to x sources' prints forever. #450

Closed
karissa opened this Issue Feb 26, 2016 · 10 comments

Comments

Projects
None yet
3 participants
@karissa
Collaborator

karissa commented Feb 26, 2016

...
  [Done] styles/SourceSansPro-BoldIt.otf
  [Done] styles/SourceSansPro-Bold.otf
  [Done] styles/SourceSansPro-BlackIt.otf
  [Done] styles/SourceSansPro-Black.otf
  [Done] styles/SIL Open Font License.txt
[Done] Files Read to Dat: 81 of 81 (1.47 MB of 1.47 MB)
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Status] Connected to 0 sources
[Sharing] dat://33e5eec886d17e10f67f726485d1533369d9926335174e4ed2a27495b908afd0^C
styles $
@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Feb 26, 2016

Collaborator

@mafintosh says he knows how to fix it

Collaborator

karissa commented Feb 26, 2016

@mafintosh says he knows how to fix it

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Feb 26, 2016

Collaborator

you have to detect that the link that is printed at the end is two lines, it assumes it is on one line

Collaborator

karissa commented Feb 26, 2016

you have to detect that the link that is printed at the end is two lines, it assumes it is on one line

@mafintosh

This comment has been minimized.

Show comment
Hide comment
@mafintosh

mafintosh Feb 26, 2016

Member

process.stdout.columns contains the width of the terminal. if what is less than the line width this will happen

Member

mafintosh commented Feb 26, 2016

process.stdout.columns contains the width of the terminal. if what is less than the line width this will happen

@mafintosh

This comment has been minimized.

Show comment
Hide comment
@mafintosh

mafintosh Feb 26, 2016

Member

maybe we can fix this in single-line-log actually ...

Member

mafintosh commented Feb 26, 2016

maybe we can fix this in single-line-log actually ...

@mafintosh

This comment has been minimized.

Show comment
Hide comment
@mafintosh

mafintosh Feb 26, 2016

Member

pasting this here for future reference, https://github.com/sindresorhus/string-width

Member

mafintosh commented Feb 26, 2016

pasting this here for future reference, https://github.com/sindresorhus/string-width

@mafintosh

This comment has been minimized.

Show comment
Hide comment
Member

mafintosh commented Feb 26, 2016

@joehand

This comment has been minimized.

Show comment
Hide comment
@joehand

joehand Feb 26, 2016

Member

@karissa does this always show up when you have a small terminal or do you need to do something to make it happen? I can reproduce if I hit return while the process is running, but the small terminal doesn't always do it.

Member

joehand commented Feb 26, 2016

@karissa does this always show up when you have a small terminal or do you need to do something to make it happen? I can reproduce if I hit return while the process is running, but the small terminal doesn't always do it.

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Feb 26, 2016

Collaborator

If the link is on two lines

Collaborator

karissa commented Feb 26, 2016

If the link is on two lines

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa
Collaborator

karissa commented Feb 26, 2016

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Feb 27, 2016

Collaborator

K opened a pr over there, waiting

Collaborator

karissa commented Feb 27, 2016

K opened a pr over there, waiting

@karissa karissa added this to the Priorities milestone Feb 27, 2016

@karissa karissa closed this in aadc489 Feb 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment