New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate logging output to own file #493

Closed
joehand opened this Issue Jun 20, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@joehand
Member

joehand commented Jun 20, 2016

10:38 AM <•mafintosh> jhand: we should refactor the logger into a separate file in dat
10:39 AM <jhand> mafintosh: ya I've thought about that but couldn't quite see how it'd work. What were you thinking?
10:41 AM <•mafintosh> jhand: lets me a simple internal object in the dat folder that encapsulates the adding of files and stuff and emits events. not a js api - just something that encapsulates the js parts of it without logging anything
10:41 AM <•mafintosh> jhand: then we just listen for events and update the output
10:41 AM <•mafintosh> thats usually a cleaner
10:42 AM <jhand> mafintosh: ah ya. that makes sense. 
10:43 AM <•mafintosh> jhand: and the js event will be internal so its okay to just make it suit the internal needs and not make it a generic thing. it just shouldn't log anything
10:44 AM <jhand> mafintosh: ya, when I was thinking about it before it just seemed like going back to a JS API. but i guess we only need to support what we need. 
10:45 AM <•mafintosh> jhand: i have an example in old project i did here, https://github.com/mafintosh/hms
10:45 AM <•mafintosh> jhand: i have the js objects in the lib folder and then i add all the logs in the commands folder. no public js api

Will make #491 easier.

@joehand joehand self-assigned this Jun 20, 2016

@joehand joehand added the in progress label Jun 20, 2016

@joehand

This comment has been minimized.

Show comment
Hide comment
@joehand
Member

joehand commented Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment