/dat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --tsv import/export option to cli #232

Merged
merged 4 commits into from Dec 4, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ekg @maxogden @joyrexus
@ekg
Contributor

ekg commented Dec 3, 2014

Instead of --csv --separator=$'\t', simply specify --tsv. The same works for both import and export. This includes tests for csv and tsv stdin import.

joyrexus and others added some commits Dec 2, 2014

@joyrexus
detect .tsv file extension
5630973
@ekg
add --tsv command-line option 
Tab-separated tables (.tsv) are really common in unix-based informatics
pipelines. Adding a --tsv cli option makes it much simpler to pipe in and out
tab-separated data.
53ada6b
@ekg
test for csv and tsv import from stdin
61b74ff

@ekg ekg referenced this pull request Dec 3, 2014

Closed

importing tab-separated data #217

@maxogden

This comment has been minimized.

Show comment
Hide comment
@maxogden

maxogden Dec 4, 2014

Member

@ekg I merged #229 first, and now I get conflicts w/ this one. I don't wanna mess up anything, so would you mind rebasing this against dat@master?
Member

maxogden commented Dec 4, 2014

@ekg I merged #229 first, and now I get conflicts w/ this one. I don't wanna mess up anything, so would you mind rebasing this against dat@master?
@ekg

This comment has been minimized.

Show comment
Hide comment
@ekg

ekg Dec 4, 2014

Contributor

Will do.
On Dec 4, 2014 12:44 AM, "Max Ogden" notifications@github.com wrote:

@ekg https://github.com/ekg I merged #229
#229 first, and now I get conflicts
w/ this one. I don't wanna mess up anything, so would you mind rebasing
this against dat@master?

—
Reply to this email directly or view it on GitHub
#232 (comment).
Contributor

ekg commented Dec 4, 2014

Will do.
On Dec 4, 2014 12:44 AM, "Max Ogden" notifications@github.com wrote:

@ekg https://github.com/ekg I merged #229
#229 first, and now I get conflicts
w/ this one. I don't wanna mess up anything, so would you mind rebasing
this against dat@master?

—
Reply to this email directly or view it on GitHub
#232 (comment).
@ekg
Merge https://github.com/maxogden/dat 
Resolve conflicts due to basing this on another PR.

Conflicts:
	bin/import.js
	lib/commands.js
	test/tests/cli.js
6f3dfef
@ekg

This comment has been minimized.

Show comment
Hide comment
@ekg

ekg Dec 4, 2014

Contributor

Done. Tests pass locally. We'll see what Mr. Travis says.
Contributor

ekg commented Dec 4, 2014

Done. Tests pass locally. We'll see what Mr. Travis says.

maxogden added a commit that referenced this pull request Dec 4, 2014

@maxogden
Merge pull request #232 from ekg/master 
add --tsv import/export option to cli
Loading status checks…
c339a76

@maxogden maxogden merged commit c339a76 into datproject:master Dec 4, 2014
1 check passed

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment