Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd compound keys to dat import #373
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mafintosh
Aug 5, 2015
Member
Instead of adding a new flag we could also implement this by adding multiple --key flags
dat import -k city -k state -k country
Using minimist that gets parsed as argv.key === ['city', 'state', 'country']
|
Instead of adding a new flag we could also implement this by adding multiple
Using minimist that gets parsed as |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
karissa
Aug 5, 2015
Collaborator
If the field in question has a comma in it, would that interfere?
On Wednesday, August 5, 2015, Mathias Buus notifications@github.com wrote:
Instead of adding a new flag we could also implement this by adding
multiple --key flagsdat import -k city -k state -k country
Using minimist that gets parsed as argv.key === ['city', 'state',
'country']—
Reply to this email directly or view it on GitHub
#373 (comment).
Karissa McKelvey
http://karissa.github.io/ http://karissamck.com
Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc
|
If the field in question has a comma in it, would that interfere? On Wednesday, August 5, 2015, Mathias Buus notifications@github.com wrote:
Karissa McKelvey Send me an encrypted message: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
karissa
Aug 5, 2015
Collaborator
I like your interface
On Wednesday, August 5, 2015, Karissa McKelvey karissa.mckelvey@gmail.com
wrote:
If the field in question has a comma in it, would that interfere?
On Wednesday, August 5, 2015, Mathias Buus <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:Instead of adding a new flag we could also implement this by adding
multiple --key flagsdat import -k city -k state -k country
Using minimist that gets parsed as argv.key === ['city', 'state',
'country']—
Reply to this email directly or view it on GitHub
#373 (comment).Karissa McKelvey
http://karissa.github.io/ http://karissamck.comSend me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc
Karissa McKelvey
http://karissa.github.io/ http://karissamck.com
Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc
|
I like your interface On Wednesday, August 5, 2015, Karissa McKelvey karissa.mckelvey@gmail.com
Karissa McKelvey Send me an encrypted message: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@mafintosh okay, updated. thoughts? |
karissa commentedAug 5, 2015
@maxogden @mafintosh pls review? :)
fixes #372