New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compound keys to dat import #373

Merged
merged 3 commits into from Aug 11, 2015

Conversation

Projects
None yet
2 participants
@karissa
Collaborator

karissa commented Aug 5, 2015

@maxogden @mafintosh pls review? :)

fixes #372

@mafintosh

This comment has been minimized.

Show comment
Hide comment
@mafintosh

mafintosh Aug 5, 2015

Member

Instead of adding a new flag we could also implement this by adding multiple --key flags

dat import -k city -k state -k country

Using minimist that gets parsed as argv.key === ['city', 'state', 'country']

Member

mafintosh commented Aug 5, 2015

Instead of adding a new flag we could also implement this by adding multiple --key flags

dat import -k city -k state -k country

Using minimist that gets parsed as argv.key === ['city', 'state', 'country']

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Aug 5, 2015

Collaborator

If the field in question has a comma in it, would that interfere?

On Wednesday, August 5, 2015, Mathias Buus notifications@github.com wrote:

Instead of adding a new flag we could also implement this by adding
multiple --key flags

dat import -k city -k state -k country

Using minimist that gets parsed as argv.key === ['city', 'state',
'country']


Reply to this email directly or view it on GitHub
#373 (comment).

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

Collaborator

karissa commented Aug 5, 2015

If the field in question has a comma in it, would that interfere?

On Wednesday, August 5, 2015, Mathias Buus notifications@github.com wrote:

Instead of adding a new flag we could also implement this by adding
multiple --key flags

dat import -k city -k state -k country

Using minimist that gets parsed as argv.key === ['city', 'state',
'country']


Reply to this email directly or view it on GitHub
#373 (comment).

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Aug 5, 2015

Collaborator

I like your interface

On Wednesday, August 5, 2015, Karissa McKelvey karissa.mckelvey@gmail.com
wrote:

If the field in question has a comma in it, would that interfere?

On Wednesday, August 5, 2015, Mathias Buus <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Instead of adding a new flag we could also implement this by adding
multiple --key flags

dat import -k city -k state -k country

Using minimist that gets parsed as argv.key === ['city', 'state',
'country']


Reply to this email directly or view it on GitHub
#373 (comment).

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

Collaborator

karissa commented Aug 5, 2015

I like your interface

On Wednesday, August 5, 2015, Karissa McKelvey karissa.mckelvey@gmail.com
wrote:

If the field in question has a comma in it, would that interfere?

On Wednesday, August 5, 2015, Mathias Buus <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Instead of adding a new flag we could also implement this by adding
multiple --key flags

dat import -k city -k state -k country

Using minimist that gets parsed as argv.key === ['city', 'state',
'country']


Reply to this email directly or view it on GitHub
#373 (comment).

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Aug 7, 2015

Collaborator

@mafintosh okay, updated. thoughts?

Collaborator

karissa commented Aug 7, 2015

@mafintosh okay, updated. thoughts?

Show outdated Hide outdated lib/import.js

karissa added a commit that referenced this pull request Aug 11, 2015

Merge pull request #373 from maxogden/compound-keys
Add compound keys to dat import

@karissa karissa merged commit ce996ea into master Aug 11, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@karissa karissa deleted the compound-keys branch Aug 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment