Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to hyperswarm #40

Open
okdistribute opened this issue Sep 26, 2019 · 5 comments

Comments

@okdistribute
Copy link
Collaborator

@okdistribute okdistribute commented Sep 26, 2019

The dat CLI is currently using discovery-swarm, which attempts to connect over a dht (which fails) but also opportunistically tries mdns and dns. Hyperswarm introduces a new DHT which we want to integrate here to replace the DHT that isn't working. Hyperswarm also has holepunching!! This will be great for the CLI.

What do you think about retiring discovery-swarm/channel completely and using as much of hyperswarm as possible, but also adding support for mdns and dns-discovery in this repository. Then we can use this repository in the dat v2 CLI.

Option 2 would be to update the discovery code in hyperswarm/discovery so that it also tries mdns and dns. Then this hyperdiscovery repository would not be needed and could be retired.

Thoughts, @RangerMauve @mafintosh @andrewosh ?

@RangerMauve

This comment has been minimized.

Copy link
Contributor

@RangerMauve RangerMauve commented Nov 8, 2019

I was thinking of retiring hyperdiscovery alltogether as part of the migration to Dat 2. The wire formats aren't backwards compatible so I don't know if having a mix of discovery-channel things and hyperswarm would give us any gains.

@mafintosh

This comment has been minimized.

Copy link
Member

@mafintosh mafintosh commented Nov 8, 2019

+1 on retiring. See hyperswarm/replicator for the api equivalent ish hyperswarm one

@okdistribute

This comment has been minimized.

Copy link
Collaborator Author

@okdistribute okdistribute commented Nov 9, 2019

Great, so we will need mdns support with hyperswarm, is that already possible or would pr be welcome there? @mafintosh

@mafintosh

This comment has been minimized.

Copy link
Member

@mafintosh mafintosh commented Nov 9, 2019

It has mdns yes. I think @RangerMauve was interested in moving it to full bonjour in the future if feasible

@RangerMauve

This comment has been minimized.

Copy link
Contributor

@RangerMauve RangerMauve commented Nov 10, 2019

Oo, yeah also @sammacbeth was interested in Bonjour. 😁

I'm currently working on hyperswarm-proxy and I might have spare dev cycles after that depending on the progress of hypercore8 integration with corestore and the such (since I'm waiting on it to continue SDK integration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.