Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDraft: HTTP Pinning Service API DEP #19
Conversation
pfrazee
added some commits
Apr 1, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I plan to specify that and each route in detail
|
joehand
referenced this pull request
Apr 4, 2018
Open
Discussion: dat publish & registry API DEP #14
pfrazee
added some commits
Apr 4, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pfrazee
Apr 11, 2018
Member
Working implementation is available at https://github.com/beakerbrowser/homebase
|
Working implementation is available at https://github.com/beakerbrowser/homebase |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pfrazee
Apr 17, 2018
Member
I put together a client module as well, no dependencies, runs automated tests against homebase: https://github.com/beakerbrowser/dat-pinning-service-client
|
I put together a client module as well, no dependencies, runs automated tests against homebase: https://github.com/beakerbrowser/dat-pinning-service-client |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RangerMauve
Apr 17, 2018
Is there a requirement for these services to have CORS headers so that they could be interacted with from within a webpage?
RangerMauve
commented
Apr 17, 2018
|
Is there a requirement for these services to have CORS headers so that they could be interacted with from within a webpage? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Would we want CORS to be enabled? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RangerMauve
Apr 17, 2018
If CORS isn't set to * you won't be able to do POSTs in JS AFAIK.
Not sure if there were more caveats for the dat:// origin.
RangerMauve
commented
Apr 17, 2018
|
If CORS isn't set to Not sure if there were more caveats for the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pfrazee
Apr 17, 2018
Member
Yeah I'm not sure we want to enable web pages to do that yet. Users would have to give their username/password to the site to do the login flow. For Beaker, I suspect we'd want to create some kind of utility for managing that access.
|
Yeah I'm not sure we want to enable web pages to do that yet. Users would have to give their username/password to the site to do the login flow. For Beaker, I suspect we'd want to create some kind of utility for managing that access. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RangerMauve
Apr 17, 2018
I originally wrote a big rant, but the summary is that I think that nudging people to provide CORS headers for all PSAs will enable more interesting applications. Even if you don't want to explicitly require it now, this can be changed in the future and could be enabled by hosts that want to allow it.
My original rant
I get the use case for beaker, but I could envision people making apps for doing similar things that could work with these services regardless of browser. If Beaker provides a great way to integrate with these services, people are less likely to go apps that implement the same thing.I could however see myself making a private app so I can manage my dats from either Beaker, Bunsen (before they integrate it), or the upcoming browser extensions. Locking these services to make them only usable to the browser runtime itself will make it harder to innovate.
I agree that a pinning service that takes credentials might want to be more guarded against letting web apps use it, but I could see pinning services without credentials, or completely different (e.g. discovery) services that would be more useful if apps could do whatever they wanted with them.
Explicitly specifying that only browsers will be using the DEPs will set a precedent that will stifle innovation and could lead to PSAs being used by beaker and not by third parties.
RangerMauve
commented
Apr 17, 2018
|
I originally wrote a big rant, but the summary is that I think that nudging people to provide CORS headers for all PSAs will enable more interesting applications. Even if you don't want to explicitly require it now, this can be changed in the future and could be enabled by hosts that want to allow it. My original rantI get the use case for beaker, but I could envision people making apps for doing similar things that could work with these services regardless of browser. If Beaker provides a great way to integrate with these services, people are less likely to go apps that implement the same thing.I could however see myself making a private app so I can manage my dats from either Beaker, Bunsen (before they integrate it), or the upcoming browser extensions. Locking these services to make them only usable to the browser runtime itself will make it harder to innovate. I agree that a pinning service that takes credentials might want to be more guarded against letting web apps use it, but I could see pinning services without credentials, or completely different (e.g. discovery) services that would be more useful if apps could do whatever they wanted with them. Explicitly specifying that only browsers will be using the DEPs will set a precedent that will stifle innovation and could lead to PSAs being used by beaker and not by third parties. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
That's a fair point. |
pfrazee
changed the title from
WIP: HTTP Pinning Service API DEP
to
Draft: HTTP Pinning Service API DEP
Apr 18, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bnewbold
Apr 18, 2018
Contributor
This looks good to me for Draft status.
We do usually want a "Privacy" section for standard/protocol DEPs, even if it's just a "no privacy concerns" or "this is for public/published works only" context note.
|
This looks good to me for Draft status. We do usually want a "Privacy" section for standard/protocol DEPs, even if it's just a "no privacy concerns" or "this is for public/published works only" context note. |
pfrazee
added some commits
Apr 18, 2018
pfrazee
merged commit 539c2ab
into
datprotocol:master
Apr 18, 2018
pfrazee
deleted the
pfrazee:pinning-service-api-dep
branch
Apr 18, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
millette
Apr 19, 2018
Did you mean to link to archive.org instead of direct a link? It appears twice.
millette
commented
Apr 19, 2018
|
Did you mean to link to archive.org instead of direct a link? It appears twice. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pfrazee
Apr 19, 2018
Member
@millette yes, that was intentional to make sure the linked target doesnt change
|
@millette yes, that was intentional to make sure the linked target doesnt change |
pfrazee commentedApr 1, 2018
•
edited
Implementations: