-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD friendliness #5
Comments
oh! so I can pass
This is what I currently ended up doing :
|
@wind57 I forgot to put myself as a watcher to this repo, so I missed your issue - sorry about that 😞 I'm glad to see that you find a workaround, but I still want to answer your questions:
I'm wondering why do parse Datree's output? If it fails, it should have exit code 1 anyway... |
FYI, our latest update includes a small change to the way we generate these |
Right. But what is the use of that to the people using this? I mean I would like to show a human readable error message of what went wrong and where. So I wanted to use It seems you validate errors vs "suggestions" differently, which makes my code really involved. Let me explain:
Good. I can check if the output has
I get a json that contains and run :
Yeah, no imho, a simpler type like:
So my suggestion is a unified, single place, for errors. I hope this makes sense. @dimabru as to your suggestion, you should really maintain a "mapping"... What I mean by that: if I have 20 manifest files in a single helm chart and I display the error being in Thank you. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The output is provided by Datree CLI and not the plugin so I open a new issue there. |
An interesting tool overall!
I do not see a way to use it in a CI/CD env, unless I am missing the obvious.
It would be great if it had something along the lines of
--quiet
and--error-count
, so that I could parse the result ofhelm datree test ...
and find our if I need to fail the build or not. Currently this is very cumbersome to do (I get the output and parse it, which to put it mildly, simply sucks).Thank you for looking into this.
The text was updated successfully, but these errors were encountered: