Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breadcrumb drops a directory when its has a same name. #54

Closed
laapsaap opened this issue Jun 5, 2018 · 3 comments
Closed

breadcrumb drops a directory when its has a same name. #54

laapsaap opened this issue Jun 5, 2018 · 3 comments
Labels

Comments

@laapsaap
Copy link

laapsaap commented Jun 5, 2018

Hi there again :)

I noticed some unexpected behavior, not sure if its intended or not.
So the breadcrumb feature works fine in general, but in one case its a bit odd.

So lets say this is my directory hierachy for docs

for ./docs/office/webserver/dc1/bla.md
the breadcrumb trail wil be: office > webserver > dc1 > bla

for. /docs/office/webserver/office/bla.md
the breadcrumb trail wil be: office > webserver > bla

So in the second case, when the directory has the same name further down the hierachy, it drops it in the breadcrumb. Is this a bug? In the MENU its listed correctly.

ps: I am using latest version.

@laapsaap
Copy link
Author

laapsaap commented Jun 5, 2018

ahh it must be a bug, because $page['breadcrumb_trail'] is an array and uses the DIRECTORY NAME as the key. So in the second example its only an array with two keys. Oops.

@onigoetz
Copy link
Contributor

onigoetz commented Jun 5, 2018

Oh, good catch :) I'll have a look

@onigoetz onigoetz added the bug label Jun 5, 2018
@onigoetz
Copy link
Contributor

onigoetz commented Jun 5, 2018

That was an easy fix, it's released in 0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants