Added native support for an additional variety of popular video players for enhanced tumblr/blog support: #40

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

funny or die, apple trailers (still buggy but becomes fluid anyway), brightcove, blip, break, traileraddict, yahoo movies, dailymotion, metacafe, mtv video. It's important for blogs to have wide spectrum support across the board for a lot of video types since you don't know where you'll be blogging from or if you'll have control over video embeds. Tumblr is a good example due to its reblogging feature. I was running into that issue. Just thought I would tack on some more video players that aren't as common.

Added native support for a variety of popular video players, funny or…
… die, apple trailers (still buggy but becomes fluid anyway), brightcove, blip, break, traileraddict, yahoo movies, dailymotion, metacafe, mtv video. It's important for blogs to have wide spectrum support across the board for a lot of video types since you don't know where you'll be blogging from or if you'll have control over video embeds. Tumblr is a good example due to its reblogging feature.
Owner

davatron5000 commented Mar 19, 2012

Thanks for the work! Before I make this live change, did you test all of these players to see if FitVids worked correctly? Maybe add an embeds for each type of player into the tests.html and we can verify that it all works as expected.

So I updated the tests.html with a few of the players (I added html comments). Ha I'm at work right now so I can't really dedicate my time to tracking down the others. But I do have ALOT of videos posted on my blog (which uses a modified version of your plugin) for you guys to check out: http://ialreadydontlikeyou.tumblr.com/tagged/video

I just checked through the blog page, it appears to work for collagehumour… but the rest of the videos posted (afaik) are youtube or vimeo… so it can't really constitute as a test for the rest of these video types.

andyadams pushed a commit to andyadams/FitVids.js that referenced this pull request Aug 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment