Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Nov 21, 2009
  1. @grimen @justinfrench
  2. @grimen @justinfrench

    Label-issues:

    grimen authored justinfrench committed
      * Inputs with legends as labels now got class "label" on the legend to make the styling of these much easier.
      * Inputs with legends as labels now wraps a label instead of a span, and the label is "connected" (with the "for" HTML attribute) to the first of the wrapped inputs - clicking label gives focus to this input. Reasons: Better form accessibility/usability, and is semantically more correct.
      * Removed: :as_span-option for the Formtastic label helper - not needed anymore.
    
    Closes #101.
  3. @grimen @justinfrench

    Added documentation for the form generator in README, and showing som…

    grimen authored justinfrench committed
    …e instructions on plugin and gem installation. Closes #118.
  4. @grimen @justinfrench

    It's now possible to specify hidden input value using html_options[:v…

    grimen authored justinfrench committed
    …alue] as well - for consistency, i.e. avoiding confusion.
  5. @grimen @justinfrench
  6. @grimen @justinfrench

    Enhanced the Rakefile a bit to make it handle missing RSpec dependenc…

    grimen authored justinfrench committed
    …y errors a bit smoother. Also added support for Jeweler::GemcutterTasks.
  7. @grimen @justinfrench

    Rakefile: Updated Jeweler LoadError-message to mention Gemcutter gem …

    grimen authored justinfrench committed
    …instead on the old GitHub one - to avoid any confusion.
  8. @grimen @justinfrench

    Fixing a Ruby 1.8 bug introduced in on of the previous commits. Specs…

    grimen authored justinfrench committed
    … run and pass on 1.8, 1.9.1, and jruby.
  9. @justinfrench

    Revert "This reverts commit 440bd2d."

    justinfrench authored
    This reverts commit e4fc2be.
Commits on Nov 18, 2009
  1. @justinfrench

    This reverts commit 440bd2d.

    justinfrench authored
    This reverts commit 8eaa193.
    This reverts commit 8c20fb2.
    This reverts commit 3cad250.
    This reverts commit 269e530.
    This reverts commit e3c200a.
  2. @grimen @justinfrench

    Added support explicit values of type Range for the :collection optio…

    grimen authored justinfrench committed
    …n of the select input, e.g. form.input :rating, :as => :select, :collection => 1..5. Added specs for both ranges, and explicit array values which was lacking. Closes #115.
  3. @grimen @justinfrench

    Even more explicit namespace for the cause of paranoia (to avoid issu…

    grimen authored justinfrench committed
    …es similar to the recent I18n in Ruby 1.9+), but also a good convention: Formtastic => ::Formtastic
  4. @grimen @justinfrench

    Comment for protected helper method added in previous commit, and mak…

    grimen authored justinfrench committed
    …ing the only private method to protected for consistency.
  5. @grimen @justinfrench

    DRYer fieldset legends; check if first inputs block argument is a val…

    grimen authored justinfrench committed
    …id legend - the options (:name/:title) way works still, and got higher priority. Closes #106.
  6. @grimen @justinfrench

    Added specs for boolean select/collection, and yes/no values back to …

    grimen authored justinfrench committed
    …Symbols for convention - in a way that works this time.
  7. @grimen @justinfrench

    Adding "::" to I18n and Formtastic constants to avoid namespace issue…

    grimen authored justinfrench committed
    …s (especially a issue in Ruby 1.9). Closes #109.
Commits on Nov 16, 2009
  1. @justinfrench
Commits on Nov 15, 2009
  1. @justinfrench

    ensure that deprecation errors are always shown in specs... if you wa…

    justinfrench authored
    …nt to write tests for a deprecation, silence/enable them in a before/after block
  2. @justinfrench
  3. @justinfrench
  4. @justinfrench
Commits on Nov 14, 2009
  1. @justinfrench
  2. @justinfrench
  3. @justinfrench
  4. @justinfrench

    added a macro for error logic specs, which is being called in almost …

    justinfrench authored
    …all input specs now, which has beefed coverage right up
  5. @justinfrench
  6. @justinfrench

    removed redundant spec

    justinfrench authored
  7. @justinfrench

    Spec Refactor:

    justinfrench authored
    * replaced a bunch of verbose and repetitive specs with macros
    * now that we have macros, we can be more verbose with the input specs, rather than looping over magical hashes
  8. @justinfrench

    documentation

    justinfrench authored
  9. @justinfrench
  10. @justinfrench

    Refactored the code and specs to be more verbose and explicit about t…

    justinfrench authored
    …he path through the code and which :as options map to which methods inside the code. More to come, but I'm trying to make the code more accessible and readable.
  11. @justinfrench

    removed some of the specificity from the option group specs so that t…

    justinfrench authored
    …hey pass on my machine and runcoderun, no idea if they passed for the original author, but everything looks okay
  12. @justinfrench

    Added :group_by option to select input (issue #54)

    Jeroen van Dijk authored justinfrench committed
    E.g.
      f.input :author, :group_by => :continent
    
    It works a bit different compared to the #grouped_options_select method of Rails. It will collect #continent
    from each author instead of collecting authors from all continents. Under the cover it will use the Rails implementation however.
    The Rails implementation combined with ActiveRecord causes an n + 1 query problem. I have tried to minimize this but the issue remains.
Commits on Nov 10, 2009
  1. @justinfrench

    :radio inputs can now force one of the radio buttons to be pre-select…

    justinfrench authored
    …ed with the :selected option, just like :select inputs, resolving issue #112.
  2. @justinfrench
Something went wrong with that request. Please try again.