Add error reporting for failed platform build #3

Closed
wants to merge 1 commit into
from

Conversation

2 participants
@ncw
Collaborator

ncw commented Dec 31, 2012

I was using your most excellent tool to test that go compiled under all platforms after patching it.

However I noticed (after submitting a request that didn't compile on Windows) that your tool doesn't report errors on builds. I've fixed that and made the build verbose too so the user can see that something is happening and so that I can see what went wrong when I'm testing cross compiles!

Thanks

@davecheney

This comment has been minimized.

Show comment Hide comment
@davecheney

davecheney Mar 23, 2013

Owner

Hi! Thank you for your contribution. I'm using the felixge model for contributions. I've given you access to merge this change, please feel free to merge this yourself.

Owner

davecheney commented Mar 23, 2013

Hi! Thank you for your contribution. I'm using the felixge model for contributions. I've given you access to merge this change, please feel free to merge this yourself.

ncw added a commit that referenced this pull request Apr 2, 2013

Keep track of build failures and show them at the end #3
Keep track of errors when building over all platforms and show them at
the end after all platforms have been tried. Returns an error code if
any builds failed.
@ncw

This comment has been minimized.

Show comment Hide comment
@ncw

ncw Apr 2, 2013

Collaborator

Done in commit db832bb

Collaborator

ncw commented Apr 2, 2013

Done in commit db832bb

@ncw ncw closed this Apr 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment