Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add error reporting for failed platform build #3

Closed
wants to merge 1 commit into from

2 participants

@ncw
Collaborator

I was using your most excellent tool to test that go compiled under all platforms after patching it.

However I noticed (after submitting a request that didn't compile on Windows) that your tool doesn't report errors on builds. I've fixed that and made the build verbose too so the user can see that something is happening and so that I can see what went wrong when I'm testing cross compiles!

Thanks

@davecheney
Owner

Hi! Thank you for your contribution. I'm using the felixge model for contributions. I've given you access to merge this change, please feel free to merge this yourself.

@ncw ncw referenced this pull request from a commit
@ncw ncw Keep track of build failures and show them at the end #3
Keep track of errors when building over all platforms and show them at
the end after all platforms have been tried. Returns an error code if
any builds failed.
db832bb
@ncw
Collaborator
ncw commented

Done in commit db832bb

@ncw ncw closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 31, 2012
  1. @ncw
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 1 deletion.
  1. +4 −1 crosscompile.bash
View
5 crosscompile.bash
@@ -33,7 +33,10 @@ function go-crosscompile-build-all {
for PLATFORM in $PLATFORMS; do
CMD="go-crosscompile-build ${PLATFORM}"
echo "$CMD"
- $CMD >/dev/null
+ $CMD || {
+ echo "*** FAILED BUILD $PLATFORM ***"
+ break
+ }
done
}
Something went wrong with that request. Please try again.