Improve performance for constructors #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement of an order of magnitude
…hable But slightly degrade performance by 7% on the general case.
From now on we only need to execute this command after changing tests and linux will be good to go
Owner
|
Nice stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added performance tests for the path and cycle constructors. This constructors were performing subpar.
I've improved the performance to bring it to the same level as the star graph constructor for UnweightedGraph.
For UniqueElementsGraph, I've improved the performance by 34% in the general case and by 66% when vertices are Hashable. This is possible through specialized class extensions. But in order to do so easily, UniqueElementsGraph is no longer a subclass of UnweightedGraph, which actually makes sense to me since Graph is now a protocol.