Dave Cranwell davecranwell

Organizations

@torchbox
davecranwell commented on pull request torchbox/wagtail#1075
@davecranwell

Reverted to version that supports passing of button names.

@davecranwell
@davecranwell
davecranwell commented on pull request torchbox/wagtail#1447
@davecranwell

In the interest of getting something shipped, perhaps a better solution here would be to fix the lack of extended character support in Open Sans an…

davecranwell commented on pull request torchbox/wagtail#1596
@davecranwell

Thanks for the PR, @alexgleason. From what I can see this causes problems at mobile viewing sizes: Perhaps the background just needs to be on both .…

davecranwell commented on pull request torchbox/wagtail#1601
@davecranwell

Looks fine to me. Does what it says on the tin.

davecranwell commented on pull request torchbox/wagtail#1612
@davecranwell

I'd prefer that we don't use terminology like "record" and that we also provide links towards the system we're requiring them to use, in keeping wi…

@davecranwell
@davecranwell
Add a generic styleguide page
@davecranwell
Document libjpeg/zlib etc as dependencies of PIL; add a runserver check for their presence
davecranwell commented on pull request torchbox/wagtail#1544
@davecranwell

Nice one @jordij, thanks. We'll review in due course.

@davecranwell

These were present in the LESS version from the start, but didn't seem to get used. This may just be a training issue.

@davecranwell

This seems slightly at odds with #7, where you're suggesting we remove the components folder. Both are good practice, whether or not you personally…

@davecranwell

The most recent version doesn't support IE8, which may still be required in some cases. Having said that, I don't see a reason not to update it, pr…

@davecranwell

Normalize is the other-dimensional twin of Reset. Reset removes everything - this frustratingly means you have to add lots of basic stuff back in. …

@davecranwell
davecranwell commented on issue torchbox/wagtail#257
@davecranwell

Like that idea. Our agency also does a lot of Drupal, a CMS which comes with "Authenticated Users" as a permission-able usergroup and allows for th…

davecranwell commented on issue torchbox/wagtail#1608
@davecranwell

Agree with this approach. Will action.

@davecranwell
Documentation required regarding Rich Text image alignment classes
@davecranwell
Text wrap on image does not work as expected
davecranwell commented on issue torchbox/wagtail#1599
@davecranwell

Wagtail does not generate any CSS for your front end, it only adds the classes to the elements. It's up to the author to write this CSS. The docum…

davecranwell commented on issue torchbox/wagtail#1595
@davecranwell

As this ticket is closed and seemed pretty unique to your set up I wouldn't bother uploading a print screen of the process. I'm sure you have bette…

davecranwell commented on pull request torchbox/wagtail#1571
@davecranwell

@gasman true, fields called page wouldn't be best practice. Either way I'm not precious about self, I wouldn't mind it changed for better compatibi…

davecranwell commented on pull request torchbox/wagtail#1571
@davecranwell

My 2c: On the one hand self is a var I associate with internal stuff which I wouldn't expect to see exposed in a django template's context. And on …

davecranwell commented on pull request torchbox/wagtail#1534
@davecranwell

Master only holds the next release so everything must be reviewed and 100% complete. We don't expect your code to be bulletproof and perfect though…

davecranwell commented on issue torchbox/wagtail#1510
@davecranwell

Use SCSS maps to rewrite all use of z-index https://css-tricks.com/handling-z-index/

davecranwell commented on issue torchbox/wagtail#1083
@davecranwell

@kaedroho is this issue still relevant? The link in your opening comment is dead.

@davecranwell
UI improvements
davecranwell commented on issue torchbox/wagtail#1586
@davecranwell

This is currently not supported. Given our current UI workflow, the creation of a new snippet "on the fly" would be expected to be achieved inside …