Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth digest responses get proxied to udp irrespective of original uri transport #45

Closed
rjp44 opened this issue Jul 4, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@rjp44
Copy link
Contributor

commented Jul 4, 2019

When a 401 auth challenge is received for a request (e.g. REGISTER) sent using TCP or TLS transports, the response reply is always proxied to sip:<ip_address>:<port> on the default UDP transport which breaks the exchange.
This is caused by the code around line 107 of digest-client.js which is trying to avoid new DNS lookups but in doing loses critical elements of the original uri.
Have a proto-fix, will test and submit a PR shortly.

@davehorton davehorton closed this in cb0be18 Jul 4, 2019

davehorton added a commit that referenced this issue Jul 4, 2019

Merge pull request #46 from rjp44/auth-challenge-fix
Honour original uri transport in challenge response fixes #45
@davehorton

This comment has been minimized.

Copy link
Owner

commented Jul 4, 2019

Thank you! will push this in a release today or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.