Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB column name 'public' is a reserved keyword in MSSQL #44

Closed
davemckain opened this issue Mar 24, 2014 · 1 comment
Closed

DB column name 'public' is a reserved keyword in MSSQL #44

davemckain opened this issue Mar 24, 2014 · 1 comment
Labels
bug

Comments

@davemckain
Copy link
Owner

One of the mapped database column names 'public' specified in the JPA annotations is a reserved word in Microsoft SQL Server, so is causing problems there.

This will need to be renamed. It would be worth checking all other mappings too to ensure they're not reserved in any of the most common DB products.

(Note that existing installations will need to make a schema change once this has been fixed.)

Thanks to Kevin Curley for pointing this out.
@davemckain davemckain added the bug label Mar 24, 2014
davemckain added a commit that referenced this issue Apr 1, 2014
@davemckain
Final tidy of DB column naming. Fixes issue #44
6737dd7 
* Dropped the 'public' field from the Assessment and DeliverySettings
entities. This idea was never developed from my initial plans, and the
existing DB column names caused clashes.
* Renamed other DB column names to avoid those listed in the URL below,
which lists a superset of keywords reserved in various well-known DB
systems.

https://drupal.org/node/141051

Thanks to Kevin Curley for reporting this issue. These changes should
fix bug #44.

NOTE: Existing QTIWorks installations will have to perform a schema
migration for this. See the script
support/schema-migrations/beta5-to-beta6.sql, which will work for
PostgreSQL installations and can be used as a guide for other DBs. If
you have no real data you may want to wipe and reinstall the DB.
@davemckain
Copy link
Owner Author

This was fixed in commit 6737dd7, along with other potential name clashes taken from the list in [1].

NB: If you have an existing QTIWorks installation then you'll need to update your schema. There's a migration script (for PostgreSQL) in support/schema-migrations/beta5-to-beta6.sql

I'm not planning any more DB changes before the release of 1.0.0 final.

[1] https://drupal.org/node/141051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davemckain