Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @Nullable and @NonNull annotations for Kotlin use #403

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

sfeatherstone
Copy link
Contributor

@sfeatherstone sfeatherstone commented Mar 8, 2018

This library already has a strong notion of when parameters should or should not be null. This formalises this contract in a way that Kotlin recognises.

  • I have suppressed warnings now generated by adding the annotations. In all cases, I have checked the code flow to ensure that the warning suppression is correct.

Note: ImageDecoder.decode() The context is not marked as @NotNull because files do not require a context to be set. All other URI type would result in a NPE

Formatting follows exist code and Google java style guide.

…ility.

- Suppressed lint warnings caused by Annotations.
@davemorrissey davemorrissey merged commit b8cd7d0 into davemorrissey:master Mar 9, 2018
@davemorrissey
Copy link
Owner

Nice, thanks! I'll try this out in the kotlin sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants