Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

TODOs. Restore block-comment-first-line strictness tmp removed in las…

…t commit
  • Loading branch information...
commit f5e36bec4e9c39160b3d940cd2530e7e770e9580 1 parent 9161186
@trentm trentm authored
Showing with 7 additions and 7 deletions.
  1. +4 −0 TODO.txt
  2. +3 −7 jsstyle
View
4 TODO.txt
@@ -0,0 +1,4 @@
+- ./jsstyle -h -> help
+- ./jsstyle --help -> still looking for input
+- ./jsstyle -f trent.conf -o doxygen examples/comments.js # working through this
+- ./jsstyle -o option -> merge with config file handling
View
10 jsstyle
@@ -160,9 +160,7 @@ if ($doxygen_comments) {
# doxygen comments look like "/*!" or "/**"; allow them.
$hdr_comment_start = qr/^\s*\/\*[\!\*]?$/;
} else {
- #XXX What is impact of allowing content after `/* here` on other
- # checks?
- $hdr_comment_start = qr/^\s*\/\*/;
+ $hdr_comment_start = qr/^\s*\/\*$/;
}
# Note, following must be in single quotes so that \s and \w work right.
@@ -467,10 +465,8 @@ line: while (<$filehandle>) {
err("continuation line not indented by 4 spaces");
}
- if (/^\s*\/\*./ && !/^\s*\/\*.*\*\//
- #XXX Update this for $hdr_comment_start and add config option for this err.
- #&& !/$hdr_comment_start/
- ) {
+ # A multi-line block comment must not have content on the first line.
+ if (/^\s*\/\*./ && !/^\s*\/\*.*\*\// && !/$hdr_comment_start/) {
err("improper first line of block comment");
}
Please sign in to comment.
Something went wrong with that request. Please try again.