Permalink
Browse files

Removing reek

Too many false negatives
  • Loading branch information...
1 parent aa2f5a3 commit 4888aed2cfe1e888ec8acaaa3ce22ea762649ab4 @davetron5000 committed Apr 10, 2012
Showing with 1 addition and 128 deletions.
  1. +1 −9 Rakefile
  2. +0 −1 gli.gemspec
  3. +0 −118 test/gli.reek
View
@@ -9,7 +9,6 @@ require 'rubygems/package_task'
require 'rake/testtask'
require 'rdoc/task'
require 'grancher/task'
-require 'reek/rake/task'
require 'roodi'
require 'roodi_task'
require 'cucumber'
@@ -37,13 +36,6 @@ spec = eval(File.read('gli.gemspec'))
Gem::PackageTask.new(spec) do |pkg|
end
-Reek::Rake::Task.new do |t|
- t.ruby_opts << '-rubygems'
- t.fail_on_error = true
- t.config_files = ['test/gli.reek']
- t.source_files = FileList['lib/**/*.rb'] - FileList['lib/support/*.rb']
-end
-
RoodiTask.new do |t|
t.patterns = ['lib/*.rb','lib/gli/*.rb']
t.config = 'test/roodi.yaml'
@@ -89,5 +81,5 @@ end
desc 'Publish rdoc on github pages and push to github'
task :publish_rdoc => [:rdoc,:publish]
-task :default => [:test,:features,:roodi,:reek]
+task :default => [:test,:features,:roodi]
View
@@ -38,7 +38,6 @@ bin/gli
s.rubyforge_project = 'gli'
s.add_development_dependency('rake', '~> 0.9.2.2')
s.add_development_dependency('rdoc', '~> 3.11')
- s.add_development_dependency('reek', '~> 1.2.0')
s.add_development_dependency('roodi', '~> 2.1.0')
s.add_development_dependency('grancher', '~> 0.1.5')
s.add_development_dependency('rainbow', '~> 1.1.1')
View
@@ -1,118 +0,0 @@
----
-UncommunicativeParameterName:
- accept: S[]
-
- exclude: []
-
- enabled: false
- reject:
- - !ruby/regexp /^.$/
- - !ruby/regexp /[0-9]$/
- - !ruby/regexp /[A-Z]/
-LargeClass:
- max_methods: 25
- exclude: []
-
- enabled: true
- max_instance_variables: 10
-UncommunicativeMethodName:
- accept: []
-
- exclude: []
-
- enabled: true
- reject:
- - !ruby/regexp /^[a-z]$/
- - !ruby/regexp /[0-9]$/
- - !ruby/regexp /[A-Z]/
-LongParameterList:
- max_params: 5
- exclude: []
-
- enabled: true
- overrides:
- initialize:
- max_params: 6
-FeatureEnvy:
- exclude: &id001 []
-
- enabled: false
-ClassVariable:
- exclude: *id001
- enabled: false
-BooleanParameter:
- exclude: ['initialize', 'name_as_string']
- enabled: true
-IrresponsibleModule:
- exclude: *id001
- enabled: true
-UncommunicativeModuleName:
- accept:
- - Inline::C
- exclude: []
-
- enabled: true
- reject:
- - !ruby/regexp /^.$/
- - !ruby/regexp /[0-9]$/
-NestedIterators:
- ignore_iterators: []
-
- exclude:
- - option_parser
-
- enabled: true
- max_allowed_nesting: 2
-LongMethod:
- max_statements: 10
- exclude:
- - initialize
- - parse_options
- - run
- - reset
- enabled: true
-Duplication:
- allow_calls: []
-
- exclude: ['run']
-
- enabled: true
- max_calls: 3
-UtilityFunction:
- max_helper_calls: 1
- exclude: [ 'find_non_flag_index', 'override_default', 'proceed?', 'command_exists?' ,'option_parser']
-
- enabled: true
-Attribute:
- exclude: []
-
- enabled: false
-UncommunicativeVariableName:
- accept: ['_']
-
- exclude: []
-
- enabled: true
- reject:
- - !ruby/regexp /^.$/
- - !ruby/regexp /[0-9]$/
- - !ruby/regexp /[A-Z]/
-SimulatedPolymorphism:
- exclude: []
-
- enabled: true
- max_ifs: 2
-DataClump:
- exclude: []
-
- enabled: false
- max_copies: 2
- min_clump_size: 2
-ControlCouple:
- exclude: ['parse_options_helper', 'program_desc', 'program_name', 'name_as_string' ]
- enabled: true
-LongYieldList:
- max_params: 3
- exclude: []
-
- enabled: true

0 comments on commit 4888aed

Please sign in to comment.