Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review- Yirong Shen #1

Open
yshen12138 opened this issue Nov 8, 2022 · 3 comments
Open

Peer Review- Yirong Shen #1

yshen12138 opened this issue Nov 8, 2022 · 3 comments

Comments

@yshen12138
Copy link

Hi, Dave, I like the idea your are making a website about yourself, but I do think you have a lot to work on still!

Technical issue: 1. Your selfie image is crushed because you don't have it in your image file.
2.Your "my work in web tech" link is not working because you don't have the document under your project folder.
3. You haven't created links on your html page that navigate to your other pages.
Content Issue: 1. you should work on the css more for example makes the links look identical to your texts, and adjust font-size to
differentiate subtitles and content,
2. The image breaks through your text which does not look good, may use table to organize it.

@daveyc1234
Copy link
Owner

daveyc1234 commented Nov 8, 2022 via email

@daveyc1234
Copy link
Owner

daveyc1234 commented Nov 8, 2022 via email

@daveyc1234
Copy link
Owner

If this helps, I know I need help on my table and maybe improving my navigation bar into a dropdown menu. Do you think you could help me there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants