New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow deletions of individual versions #65

Merged
merged 1 commit into from Mar 25, 2016

Conversation

Projects
None yet
3 participants
@bengl
Collaborator

bengl commented Mar 24, 2016

@drewfish

This comment has been minimized.

Contributor

drewfish commented Mar 24, 2016

LGTM

@davglass

This comment has been minimized.

Owner

davglass commented Mar 25, 2016

👍

@bengl

This comment has been minimized.

Collaborator

bengl commented Mar 25, 2016

@drewfish @davglass I added two extra tests to make sure it doesn't barf on bad data, since, as we know, bad data can and does happen.

@drewfish

This comment has been minimized.

Contributor

drewfish commented Mar 25, 2016

+yep

@bengl bengl merged commit cd20ad8 into master Mar 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@davglass

This comment has been minimized.

Owner

davglass commented Mar 25, 2016

👍 This process does protect against unpublished modules, but it doesn't stop new updates to an unpublished module. What if the next step is to add a check for the unpublished key and not allow further updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment