Skip to content
Browse files

Remove throw-on-no-tty because it is not reliable.

process.stderr.isTTY is not false when it needs to be.
The check was doing more harm than good.

Thanks to Olan Byrne for reporting this issue.
http://yuilibrary.com/forum/viewtopic.php?p=33183#p33183
  • Loading branch information...
1 parent 22597ec commit 6439183210f30170a7417202cf660d11277b1b21 @reid reid committed Sep 10, 2012
Showing with 0 additions and 9 deletions.
  1. +0 −9 lib/cli.js
View
9 lib/cli.js
@@ -304,15 +304,6 @@ function runBatch(options) {
if (agents.length > 0) {
submitBatch(client, batchOptions);
} else {
- if (!isTTY) {
- // TODO Only throw this error if no agents are immediately available.
- // stderr is not a terminal, we are likely being ran by another program.
- // Fail quickly instead of waiting for browsers.
- throw "Unable to connect to Hub or start an interactive session.";
- // TODO: Allow waiting X seconds for browsers.
- // "Try running with --wait 30 to wait 30 seconds for browsers to connect.";
- }
-
var rl = readline.createInterface(process.stdin, process.stderr);
error("Waiting for agents to connect at " + url + ".");

0 comments on commit 6439183

Please sign in to comment.
Something went wrong with that request. Please try again.