Permalink
Commits on Sep 5, 2017
Commits on Aug 28, 2017
Commits on Aug 22, 2017
  1. update contributions

    davidB committed Aug 22, 2017
Commits on Jul 24, 2017
  1. Merge pull request #180 from sirmax/fix/activeByDefault-integration-t…

    davidB committed on GitHub Jul 24, 2017
    …ests
    
    Make it possible to deactivate `integration-tests` profile
Commits on Jul 20, 2017
  1. build: travis force jdk8

    davidB committed Jul 20, 2017
  2. README: update

    davidB committed Jul 20, 2017
Commits on Jul 19, 2017
  1. build: force jdk7 else some integration-test are failing with error l…

    davidB committed Jul 19, 2017
    …ike:
    
    ```
    [INFO] [ERROR] error: error while loading Consumer, class file '/usr/lib/jvm/java-8-oracle/jre/lib/rt.jar(java/util/function/Consumer.class)' is broken
    
    [INFO] [INFO] (bad constant pool tag 18 at byte 15)
    ```
  2. build: add basic .travis.yml

    davidB committed Jul 19, 2017
  3. replace String.split by StringUtils.split to avoid inconsistency of S…

    davidB committed Jul 19, 2017
    …tring.split between jdk version
    
    and restore test and comment about it
  4. Merge pull request #206 from isomarcte/crossCompilation

    davidB committed on GitHub Jul 19, 2017
    Ask java compiler to generate 1.6 compatible bytecode
Commits on Jul 17, 2017
  1. Merge pull request #207 from isomarcte/fixScalaConsole212

    davidB committed on GitHub Jul 17, 2017
    Fix scala console212
Commits on Mar 28, 2017
  1. Derive the JLine dependency from the Scala compiler.

    isomarcte committed Mar 8, 2017
    * `src/main/java/scala_maven/ScalaMojoSupport.java`
      * Added `static` values for a couple `String` values used internally in the
        class, namely "pom" and "jar". Updated usage instances of strings in the
        class to use the constants.
      * Added method to resolve the `Artifact` for the `scala-compiler`.
      * Added more general overloads for `resolveDependencyArtifacts` allowing for
        specification of various artifact filters. Changed the resolution method to
        use the non-deprecated `ArtifactResolutionRequest` type. This is the only
        non-deprecated way to resolve `Artifacts` in Maven as of now.
      * Added an overloaded variant of the `getScalaCommand` which allows
        specification the following behaviors.
        * `forkOverride` - Whether or not to `fork` regardless of the setting in the
          plugin. This currently is only used (and is in fact required) by the
          `scala:console` goal.
        * `mainClass` The JVM class to invoke as main. This currently only has
          use (and is in fact required) by the `scala:console` goal.
      * Added overloaded variant of `getEmptyScalaCommand` that also allows the same
        `forkOverride` behavior seen in `getScalaCommand`. As the former method
        delegates to this one.
      * Updated call to `resolveDependencyArtifacts` to use the
        `resolveArtifactDependencies` operating on the `Artifact` rather than the
        `MavenProject`.
    * `src/main/java/scala_maven/ScalaConsoleMojo.java`
      * Added `static` values for a couple `String` values used internally in the
        class, namely "jline" and "org.scala-lang".
      * Updated the `doExecute` method to use the `JavaMainCaller`.
      * Added several `private` methods to choose the correct `jline` dependency
        based on the `scala-compiler` artifact version and dependencies as well as a
        few that just perform general cleanup.
        * `handleJavaRebel` - This method adds the Java Rebel setup if it
          `javaRebelPath` is non-null and the target path exists. The logic this
          method performs is unchanged it was merely factored out into an isolated
          `private` method to reduce noise in the `doExecute` method.
        * `setupClassPathForConsole` - This is the top level `private` method for
          constructing the correct classpath for use with the scala console. It
          merely takes the project classpath and merges it with required console
          classpath.
        * `setupProjectClasspaths` - This method adds the scal compiler and standard
          library to the classpath. It also conditionally adds test classpath and
          runtime classpath.
        * `setupConsoleClasspaths` - Adds any console specific artifacts to the
          classpath. Currently this is just JLine.
        * `resolveJLine` - This method attempts to derive the correct
          JLine dependency to use by finding the version used as an optional
          dependency by the `scala-compiler` artifact at the given version, falling
          back to the hard coded constants that were in use prior to this commit if
          it is unable to resolve the Jline version. Note, I have not found any case
          where it does _fail_ and fallback, but I've left it in here just _in
          case_.
        * `filterForJline` - Filter predicate that is applied to the dependencies on
          the `scala-compiler` to find the JLine dependency.
        * `fallbackJLine` - Fallback constant hard coded values for JLine which are
          only used if we can not derive the correct version from the
          `scala-compiler` artifact.
Commits on Mar 27, 2017
  1. Merge pull request #205 from isomarcte/fixMavenCompat

    davidB committed on GitHub Mar 27, 2017
    Use `maven-compat` for the Maven 2 features.
Commits on Mar 22, 2017
  1. Ask java compiler to generate 1.6 compatible bytecode

    isomarcte committed Mar 22, 2017
    * `pom.xml`
      * Added `target` to the `maven-compiler-plugin` and set to `1.6`. This should
        allow us to build with JDK 1.8 and still support 1.6 clients, keeping in
        mind we can not use Java Standard Library 1.8 exclusive symbols.
    * `src/test/java/scala_maven/MiscTest.java`
      * Removed test that fails if you are using JDK > 7.
Commits on Mar 8, 2017
  1. Use `maven-compat` for the Maven 2 features.

    isomarcte committed Mar 8, 2017
    * `pom.xml`
      * Added `maven-compat` dependency which allows to usage of Maven 2 features
        with Maven 3.
      * Removed Maven 2 dependency.
    * `src/main/java/scala_maven/ScalaMojoSupport.java`
      * Removed wildcard type that was used for the Maven 2 dependency that was
        removed. Replaced it with the correct generic type, as required by
        `maven-compat`.
Commits on Jan 8, 2017
  1. Update README.md

    davidB committed on GitHub Jan 8, 2017
  2. Merge pull request #191 from cddude229/doc-corrections

    davidB committed on GitHub Jan 8, 2017
    Some small README changes
  3. Merge pull request #192 from cddude229/maven-zinc-toolchains-support

    davidB committed on GitHub Jan 8, 2017
    Zinc - Toolchains support
  4. Merge pull request #190 from cddude229/maven-site-plugin-upgrade

    davidB committed on GitHub Jan 8, 2017
    Upgrade maven-site-plugin in ITs to 3.3 so that ITs pass with Maven 3.3.3
Commits on May 4, 2016
  1. Add missing end quote

    cddude229 committed May 4, 2016
  2. Upgrade maven-site-plugin in ITs to 3.3 so that ITs pass with Maven 3…

    cddude229 committed May 4, 2016
    ….3.3
    
    Tested by running mvn integration-test, which failed without these
    changes.
    
    See
    https://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound
    for details on what this upgrade does and what was broken when I ran
    the ITs.