Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Feature Request: Sort by Likes / Dislikes #21

Closed
ehoch opened this Issue April 03, 2012 · 5 comments

2 participants

Eric Hochberger David Celis
Eric Hochberger
ehoch commented April 03, 2012

Since you've already built this awesome system to track Likes / Dislikes and give recommendations and similarities... what do you think of extending it to sort the recommendable models using an algorithm similar to:

http://evanmiller.org/how-not-to-sort-by-average-rating.html

Anyways, just thought it could fit in nicely into the Redis background and this system...

David Celis
Owner

I wasn't sure about implementing a sorting mechanism as part of the library itself. I wasn't sure if it should be recommendable's responsibility. This, however, does intrigue me, so I'm going to take a look and give it a shot. Thanks

Eric Hochberger
ehoch commented April 03, 2012

Figured if nothing else it'd be up your alley after seeing your work / blog. Let me know if you do anything with it...

David Celis davidcelis closed this in 3d9be16 April 04, 2012
David Celis
Owner

Just pushed an update to do this. I'm thinking it's time for a version bump now.

David Celis
Owner

Done! Let me know how it works, @ehoch!

Eric Hochberger
ehoch commented April 05, 2012

Oh you rock! I might not get a chance to play until next week. But upon looking through the code it looks simple and great. I might just have to submit a really simple PR to allow me to pass in an offset to self.top for pagination.

But again, can't wait to play. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.