Items that have been rated/hidden/bookmarked are recommended #55

davidcelis opened this Issue Oct 10, 2012 · 0 comments

1 participant


Items that have already been rated, hidden, or bookmarked currently appear in
recommendations. Fixing this SHOULD be easy, but is currently messing with
one of the tests. The solution (in update_recommendations_for) should be:

  1. Grab the Redis keys for liked/disliked/hidden/bookmarked sets
  2. Use Redis to SDIFF the above sets from item IDs returned by SUNIONING relevant users' liked sets
  3. Make predictions for the resulting items

For some reason, this causes
RecommenderTest#test_that_it_is_removed_from_recommendable_after_destroy to

@davidcelis davidcelis added a commit that closed this issue Oct 11, 2012
@davidcelis Don't recommend rated items - Fixes #55
Signed-off-by: David Celis <>
@davidcelis davidcelis added a commit that referenced this issue Oct 11, 2012
@davidcelis Add test for #55
Signed-off-by: David Celis <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment