Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Update miniskirt dependency to minifacture #89

Merged
merged 2 commits into from

2 participants

@alcesleo

The project was renamed, see stephencelis/minifacture#20

There should not be any code changes since it's already aliased to Factory.

Cheers!

@alcesleo alcesleo Update miniskirt dependency to minifacture
The project was renamed, see stephencelis/minifacture#20

There should not be any code changes since it's already aliased to `Factory`.

Cheers!
942374d
@davidcelis
Owner

Thanks! It looks like the build's failing though. Probably because of the require statements for miniskirt

@alcesleo

Ah, sorry I'll fix it.

@alcesleo

Hmmm, no idea why it fails now. It works on my machine and in most of the Travis runs.

@alcesleo

Alright I think I've found the cause, when he uploaded the project with the new name he only pushed the latest version, some of the tests depended on older versions.

It's complaining about not finding compatible versions of activesupport, in earlier versions there was a switch that looks like it took care of this: stephencelis/minifacture@75886f9

I'm not sure why this was changed but I'm guessing that the fix is either pushing the old versions of now Minifacture or reintroducing this dependency-switch.

@alcesleo alcesleo referenced this pull request in stephencelis/minifacture
Closed

Version incompatibilities #21

@davidcelis
Owner

Yep looks like 1.2.1 at some point introduced a pessimistic version lock on ActiveSupport 3: https://github.com/stephencelis/minifacture/blob/gem/minifacture.gemspec

Since I want to ensure Rails 4 compatibility, I'll need to wait until that's fixed to merge this in

EDIT: He fixed it!

@davidcelis davidcelis merged commit 4a10c9c into davidcelis:master

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@alcesleo

Awesome!

@alcesleo alcesleo deleted the unknown repository branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 5, 2014
  1. @alcesleo

    Update miniskirt dependency to minifacture

    alcesleo authored
    The project was renamed, see stephencelis/minifacture#20
    
    There should not be any code changes since it's already aliased to `Factory`.
    
    Cheers!
Commits on Apr 6, 2014
  1. @alcesleo
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  recommendable.gemspec
  2. +1 −1  test/test_helper.rb
View
2  recommendable.gemspec
@@ -25,7 +25,7 @@ EOF
s.add_dependency 'hooks', '>= 0.2.1'
s.add_development_dependency 'minitest', '~> 4.2'
- s.add_development_dependency 'miniskirt'
+ s.add_development_dependency 'minifacture'
s.add_development_dependency 'yard'
s.add_development_dependency 'rails', '>= 3.1.0'
s.add_development_dependency 'database_cleaner'
View
2  test/test_helper.rb
@@ -8,7 +8,7 @@
require 'database_cleaner'
-require 'miniskirt'
+require 'minifacture'
require 'factories'
require 'recommendable'
Something went wrong with that request. Please try again.