WebWorkers compatibility

[Seb-C]

The window object doesn't exists in webworkers, self must be used instead.

[davidchambers]

s/exists/exist/

[davidchambers]

Inferring the environment is an increasingly challenging issue in JavaScript projects. :\

This change seems fine to me, but I'd like to get an "LGTM" from @michaelficarra before merging it.

[michaelficarra]

@sebcap26: In a WebWorker environment, what is the result of (function(){ return this === self; }())?

[Seb-C]

It seems that "this" can also be used instead of "self" in a WebWorker.

Debugging WebWorkers is hard, so I had to do that in my webworker :

throw new Error("test : " + (self === this));

The error message in console is "test : true".

But the w3c specs refers to "self" : http://www.w3.org/TR/workers/#the-workerglobalscope-common-interface

[michaelficarra]

Then just changing window to this should be sufficient.

[davidchambers]

Then just changing window to this should be sufficient.

Very nice. Mind updating the pull request, @sebcap26?

[Seb-C]

Should I also update the minified version ? I'm not sure to have the required dependencies to "make" it :/

[davidchambers]

Try the following commands:

$ make setup
$ make test
$ make base64.min.js
$ git commit --all --amend

[Seb-C]

Error on setup :

ERR! Error: No compatible version found: source-map@'>=0.1.7- <0.2.0-'

[davidchambers]

ERR! Error: No compatible version found: source-map@'>=0.1.7- <0.2.0-'

I don't know what was going on there (works for me). I made the change and pushed to master. I'll publish a new version now.