tutor.set doesn't get all cards #66

Merged
merged 1 commit into from Jul 21, 2013

Conversation

Projects
None yet
3 participants
Owner

davidchambers commented Jul 20, 2013

There's a problem with cards that have different variations, like lands.

For example Plains in M14 have 4 variations, each with a different Artist and Collector's Number.
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370615
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370669
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370679
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370754

However, if I tutor.set 'Magic 2014', I get http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=370669 which is not even the first variation.

Unfortunately, due to the way Gatherer works, I doubt that this would be easy to fix.

Collaborator

robdennis commented Jul 20, 2013

This may have been the known issue from the "spoiler" change that allowed "all" cards in a set to be retrieved in one query.

I'd expect that if you search by tutor.card Plains and checking "versions" that'd be an ok workaround

Thanks,
-Rob

On Sat, Jul 20, 2013 at 12:44 PM, Patrick notifications@github.com
wrote:

There's a problem with cards that have different variations, like lands.
For example Plains in M14 have 4 variations, each with a different Artist and Collector's Number.
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370615
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370669
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370679
http://gatherer.wizards.com/Pages/Card/Details.aspx?printed=true&multiverseid=370754
However, if I tutor.set 'Magic 2014', I get http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=370669 which is not even the first variation.

Unfortunately, due to the way Gatherer works, I doubt that this would be easy to fix.

Reply to this email directly or view it on GitHub:
#66

Nope, even before the change to the spoilers, tutor was not able to get all variations at once.

Well, it's a rather ugly workaround, as I'd have to tutor.card each card, check "versions" for other cards in this set and then tutor.card these again, append them to the original results and sort everything. But if it's not possible otherwise, this'll have to make do.

Thanks

Owner

davidchambers commented Jul 21, 2013

I believe I've addressed the issue. To try the changes, do something along the lines of the following:

git checkout master
git checkout -b basics
git pull upstream basics  # replace "upstream" with your alias for davidchambers/tutor
make fixtures
make test

Assuming all the tests pass, go ahead and make some calls to tutor.set in the REPL. Let me know if this is the behaviour you had in mind. :)

Tests run fine and the behaviour is exactly what I had in mind. Thanks for the quick fix!

@davidchambers davidchambers merged commit c81bd40 into master Jul 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment