Collection of fixes for /memreserve/ handling #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
This fixes writing out /memreserve/ when we're reading in from a DTB. Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
If we failed and hit the parse_error, then we'd still push back whatever ended up in the start/length variables. Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Previously, we'd end up writing the start twice rather than the start followed by the length. Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Otherwise these can and should be interpreted by any dts reader as decimal constants and misinterpreted, rather than as hex constants (as implied by PRIx64). Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing and attempting to use dtc to parse out /memreserve/ nodes in the RPi DTB yielded a somewhat major issue in our dtc- there were no /memreserve/ in the output! This series fixes that and a couple of other issues with the handling; the commit messages describe the various issues I ran into.