Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use qhull for tsearchn() #6

Closed
davidcsterratt opened this issue Apr 28, 2017 · 1 comment
Closed

Use qhull for tsearchn() #6

davidcsterratt opened this issue Apr 28, 2017 · 1 comment
Assignees
@davidcsterratt
Labels
enhancement
Milestone
0.4.0

Comments

@davidcsterratt
Copy link
Owner

At present, the implementation of tsearchn() involves, for each point, testing if it is in every facet. A more efficient method would use qh_findbestfacet() (as in findDelaunay() in https://github.com/qhull/qhull/blob/master/src/user_eg/user_eg_r.c).
@davidcsterratt davidcsterratt mentioned this issue Apr 28, 2017
Closed
davidcsterratt added a commit that referenced this issue Apr 28, 2017
@davidcsterratt
Issue #6: Return qhull objects from C_delaunayn()
d145ef9 
The code has been modified in a similar way to the C_convhulln() code,
by adding a finalizer that cleans up the memory when the object is
finally destroyed.
@davidcsterratt davidcsterratt added this to the 0.4.0 milestone Apr 28, 2017
davidcsterratt added a commit that referenced this issue May 3, 2017
@davidcsterratt
Issue #6: Initial C code for qhull-based tsearchn
787d5df
@davidcsterratt
Copy link
Owner Author

This doesn't give correct ids, as facet->id does not map to the order of the facet when iterating through FOREACHfacet. Probably the solution is to create a mapping by running through FOREACHfacet to create a hash from id to sequence in list.

@davidcsterratt davidcsterratt reopened this May 3, 2017
This was referenced May 3, 2017
Closed
Closed
davidcsterratt added a commit that referenced this issue Sep 12, 2017
@davidcsterratt
Issue #6: Correct index being returned by qhull tsearchn()
691c4dc
davidcsterratt added a commit that referenced this issue Sep 19, 2017
@davidcsterratt
Issue #6: tsearchn() using qhull verified to be working on one test
9a62cb4
davidcsterratt added a commit that referenced this issue Sep 19, 2017
@davidcsterratt
Issue #6: Test for points outwith triangulation in tsearchn()
a9606ab
davidcsterratt added a commit that referenced this issue Sep 24, 2017
@davidcsterratt
Issue #6: tidied up ready for 0.4.0 release
4c28469
@davidcsterratt davidcsterratt self-assigned this May 21, 2018
davidcsterratt added a commit that referenced this issue Feb 17, 2019
@davidcsterratt
Issue #1 and #6: Check for pointer to qhull structure to prevent segf…
e7a9357 
…ault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcsterratt davidcsterratt

Labels
enhancement
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@davidcsterratt